43293[CLEANUP] Minor code improvements in DatabaseRowInitializeNew
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Nicole Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Nicole Hummel +1
Issues 1
Files 2
Review log 8
-
Loek Hilgersom uploaded patch set 1 09/14/15, 11:46
-
Loek Hilgersom commented on patch set 1 09/14/15, 11:56
Some clarifications of the de-uglifications of this patch :-)DatabaseRowInitializeNew.php:79isset doesn't add anything here on top of !empty, it's not faster either so it's just overhead.DatabaseRowInitializeNew.php:88This check doesn't make sense: moving the defaults from neighbor row up in this method does the same thing. The correct order should be: userTSconfig, pageTSconfig, neighbor row, GET/POST values. -
Michael Oehlhof voted on patch set 1 CR +1 09/14/15, 12:06
-
Nicole Hummel commented on patch set 1 CR -1 09/15/15, 08:15
Try to add tests -
Nicole Hummel uploaded patch set 2 09/15/15, 08:32
-
Nicole Hummel commented on patch set 2 CR +1 V +1 09/15/15, 08:33
Added unit tests to check the overruling of different default value methods -
Christian Kuhn voted on patch set 2 CR +2 V +2 09/15/15, 09:12
-
Christian Kuhn merged patch set 2 09/15/15, 09:12