43294[TASK] IDNA encode domains in email addresses for MailMessage
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Loek Hilgersom +1
- Wouter Wolters +1
- Nicole Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Loek Hilgersom +1
- Nicole Hummel +1
Issues 1
Files 2
Review log 18
-
Morton Jonuschat uploaded patch set 1 09/14/15, 11:58
-
Mathias Brodala uploaded patch set 2 09/14/15, 12:17
-
Mathias Brodala commented on patch set 2 09/14/15, 12:19
Use mb_check_encoding() to detect non-ASCII characters in the domain part. -
Nicole Hummel commented on patch set 2 09/15/15, 07:46
Should we cover functions addFrom(), addReplyTo(), addTo(), addCc(), addBcc() as well?MailMessage.php:211Any reason for not changing the names in the $adresses array? -
Morton Jonuschat commented on patch set 2 09/15/15, 08:11
MailMessage.php:211ReplyBecause if I have the email address as key the key actually changes if it needs encoding -
Nicole Hummel uploaded patch set 3 09/15/15, 08:14
-
Nicole Hummel commented on patch set 3 CR +1 V +1 09/15/15, 08:15
Adjusted the tests slightly. Add functions not necessary to cover as they call the setters internally. -
Christian Kuhn commented on patch set 3 CR +1 V +1 09/15/15, 08:23
please wait for a vote by Loek before merge. -
Loek Hilgersom commented on patch set 3 CR +1 V +1 09/15/15, 09:23
Verified with 'real-life' swiftmailer use. -
Wouter Wolters commented on patch set 3 CR -1 09/15/15, 09:27
commit message contains error -
Wouter Wolters commented on patch set 3 09/15/15, 09:28
issuge -> issue -
Wouter Wolters updated the commit message in patch set 4 09/15/15, 09:28
-
Wouter Wolters voted on patch set 4 CR +1 09/15/15, 09:28
-
Nicole Hummel voted on patch set 4 CR +1 V +1 09/15/15, 09:28
-
Christian Kuhn voted on patch set 4 CR +1 V +1 09/15/15, 09:29
-
Loek Hilgersom voted on patch set 4 CR +1 V +1 09/15/15, 09:29
-
Christian Kuhn voted on patch set 4 CR +2 V +2 09/15/15, 09:29
-
Christian Kuhn merged patch set 4 09/15/15, 09:29