Review main Merged

43294[TASK] IDNA encode domains in email addresses for MailMessage

Morton Jonuschat CR +2 V +2 Hard +380 −0 updated 09/15/15, 09:29

Commit message

SwiftMailer does not support email addresses with UTF8 characters in the
domain name. UTF8 characters in the domain name are valid as long as
they are IDNA/punycode encoded.

To work around the SwiftMailer issue MailMessage has been extended with
custom setters that encode the email addresses before passing them to
SwiftMailer.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Loek Hilgersom +1
    • Wouter Wolters +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Loek Hilgersom +1
    • Nicole Hummel +1

Issues 1

Files 2

Review log 18

  1. Morton Jonuschat uploaded patch set 1 09/14/15, 11:58

  2. Mathias Brodala uploaded patch set 2 09/14/15, 12:17

  3. Mathias Brodala commented on patch set 2 09/14/15, 12:19

    Use mb_check_encoding() to detect non-ASCII characters in the domain part.
  4. Nicole Hummel commented on patch set 2 09/15/15, 07:46

    Should we cover functions addFrom(), addReplyTo(), addTo(), addCc(), addBcc() as well?

    MailMessage.php:211

    Any reason for not changing the names in the $adresses array?
  5. Morton Jonuschat commented on patch set 2 09/15/15, 08:11

    MailMessage.php:211 Reply

    Because if I have the email address as key the key actually changes if it needs encoding
  6. Nicole Hummel uploaded patch set 3 09/15/15, 08:14

  7. Nicole Hummel commented on patch set 3 CR +1 V +1 09/15/15, 08:15

    Adjusted the tests slightly. Add functions not necessary to cover as they call the setters internally.
  8. Christian Kuhn commented on patch set 3 CR +1 V +1 09/15/15, 08:23

    please wait for a vote by Loek before merge.
  9. Loek Hilgersom commented on patch set 3 CR +1 V +1 09/15/15, 09:23

    Verified with 'real-life' swiftmailer use.
  10. Wouter Wolters commented on patch set 3 CR -1 09/15/15, 09:27

    commit message contains error
  11. Wouter Wolters commented on patch set 3 09/15/15, 09:28

    issuge -> issue
  12. Wouter Wolters updated the commit message in patch set 4 09/15/15, 09:28

  13. Wouter Wolters voted on patch set 4 CR +1 09/15/15, 09:28

  14. Nicole Hummel voted on patch set 4 CR +1 V +1 09/15/15, 09:28

  15. Christian Kuhn voted on patch set 4 CR +1 V +1 09/15/15, 09:29

  16. Loek Hilgersom voted on patch set 4 CR +1 V +1 09/15/15, 09:29

  17. Christian Kuhn voted on patch set 4 CR +2 V +2 09/15/15, 09:29

  18. Christian Kuhn merged patch set 4 09/15/15, 09:29