Review main Merged

43303[FEATURE] Support pecl-memcached in MemcachedBackend

Andreas Kienast CR +2 V +2 Normal +138 −35 updated 01/17/18, 15:03

Commit message

The MemcachedBackend now also supports the pecl-memcached
module. The caching backend detects which modules are installed
and uses "memcache" over "memcached" to avoid being a breaking
change. If both modules are installed, an integrator can choose the
PECL module by setting the new ``peclModule`` option.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Morton Jonuschat +1

Issues 1

Files 3

Review log 27

Show 2 earlier messages
  1. Andreas Kienast uploaded patch set 1 09/14/15, 14:44

  2. Andreas Kienast uploaded patch set 2 09/15/15, 12:38

  1. Frank Nägler voted on patch set 2 CR +1 10/05/15, 10:57

  2. Benni Mack voted on patch set 2 CR +2 10/06/15, 06:39

  3. Benni Mack voted on patch set 2 V +1 10/06/15, 14:15

  4. Christian Kuhn commented on patch set 2 V -1 10/08/15, 18:40

    travis and my own tests fail with PHP Fatal error: Call to a member function addserver() on a non-object in /home/travis/build/lolli42/TYPO3.CMS-Catharsis/typo3/sysext/core/Classes/Cache/Backend/MemcachedBackend.php on line 171
  5. Benni Mack commented on patch set 2 10/08/15, 18:41

    Hmm, I will check my setup (PHP7 customized) again, what is messed up here.
  6. Oliver Hader uploaded patch set 3 10/08/15, 23:56

  7. Benni Mack uploaded patch set 4 12/22/15, 07:21

  8. Benni Mack voted on patch set 4 CR +1 V +1 12/22/15, 07:23

  9. Markus Klein commented on patch set 4 12/22/15, 08:30

    MemcachedBackend.php:107

    this can never be false as we are in the constructor, right?

    MemcachedBackend.php:139

    kick that
  10. Benni Mack commented on patch set 4 12/22/15, 08:34

    MemcachedBackend.php:107 Reply

    nope. see parent::__construct() - it uses setUsedPeclModule() - if this is not set, the code does a "best guess".
  11. Markus Klein commented on patch set 4 CR +1 12/22/15, 08:41

    MemcachedBackend.php:107 Reply

    alright, thanks.
  12. Benni Mack commented on patch set 4 12/22/15, 14:28

    MemcachedBackend.php:139 Reply

    I would leave that. this makes sure that the integrators / admins set it to true and not to "true" or "1".
  13. Wouter Wolters voted on patch set 4 CR +1 12/24/15, 13:29

  14. Wouter Wolters commented on patch set 4 CR -1 V -1 01/02/16, 17:08

    fails for memcached
  15. Wouter Wolters uploaded patch set 5 01/02/16, 17:09

  16. Wouter Wolters commented on patch set 5 01/02/16, 17:16

    pecl-memcached has 3 parameters for set() to check is the compression option. this->flags is not used when pecl-memcached is active now
  17. Markus Klein voted on patch set 5 CR +1 01/04/16, 11:10

  18. Benni Mack commented on patch set 5 CR +2 V +1 01/11/16, 20:33

    re-applying - works fine here.
  19. Wouter Wolters commented on patch set 5 CR -1 01/11/16, 20:42

    the compression flag question still needs an answer.
  20. Morton Jonuschat uploaded patch set 6 01/15/16, 21:39

  21. Morton Jonuschat voted on patch set 6 CR +1 V +1 01/15/16, 21:40

  22. Markus Klein voted on patch set 6 CR +1 01/15/16, 21:45

  23. Wouter Wolters voted on patch set 6 CR +2 V +2 01/16/16, 12:59

  24. Gerrit merged patch set 6 01/16/16, 12:59

  25. Andreas Kienast commented on patch set 7 01/17/18, 15:03

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 2434367c05a0675b65c47d8b6a9c1d3cbcfc28c5