Review main Merged

43321[BUGFIX] Adjust itemsProcFunc for sys_filemounts

Nicole Hummel CR +2 V +2 Easy +2 −3 updated 09/15/15, 12:00

Commit message

Due to the changes of FormEngine the folder selection of filemount
records always show the folders from fileadmin. This patch adjust the
script to handle the incoming (already resolved) database information.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • Michael Oehlhof +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 11

  1. Nicole Hummel uploaded patch set 1 09/15/15, 10:12

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 09/15/15, 10:17

  3. Michael Oehlhof commented on patch set 1 09/15/15, 10:42

    UserFileMountService.php:35

    Class FormEngine is undefined Should it be FormEngineUtility ?
  4. Christian Kuhn commented on patch set 1 09/15/15, 10:48

    will push update
  5. Nicole Hummel uploaded patch set 2 09/15/15, 11:16

  6. Nicole Hummel commented on patch set 1 09/15/15, 11:16

    UserFileMountService.php:35 Reply

    It is an AbstractItemProvider but as it's not used in the function we don't need it anyway
  7. Michael Oehlhof voted on patch set 2 CR +1 09/15/15, 11:24

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 09/15/15, 11:30

  9. Michael Oehlhof voted on patch set 2 V +1 09/15/15, 11:32

  10. Wouter Wolters voted on patch set 2 V +2 CR +2 09/15/15, 12:00

  11. Wouter Wolters merged patch set 2 09/15/15, 12:00