Review main Abandoned

43326[FEATURE] Introduce PdoFileBackend

Andreas Kienast CR 0 V 0 Expert +1145 −0 updated 07/31/17, 12:59

Commit message

Introduce a PdoFileBackend which is a hybrid of PdoBackend and FileBackend.
The advantage of such new backend is, it reduces the I/O on the disk when
purging caches, which heavily increases the disk performance for very large
(> 30,000) caches. It also decreases the I/O on cache lookup per cache file
due to the lookup of the cache info in database.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 3334

Show 9 earlier messages
  1. Andreas Kienast uploaded patch set 1 09/15/15, 12:17

  2. Andreas Kienast commented on patch set 1 V -1 CR -1 09/15/15, 12:19

    Still working on it
  3. Andreas Kienast uploaded patch set 2 09/15/15, 12:36

  4. Andreas Kienast uploaded patch set 3 10/05/15, 14:06

  5. Andreas Kienast uploaded patch set 4 12/03/15, 17:04

  6. Andreas Kienast commented on patch set 3 12/03/15, 17:05

    Applied PSR-2
  7. Frank Nägler voted on patch set 4 CR +1 12/04/15, 11:20

  8. Georg Ringer voted on patch set 4 CR +1 V +1 12/05/15, 21:03

  9. Frank Nägler commented on patch set 4 12/14/15, 10:32

    because it is a feature, we need to wait for branching, v8 only.
  1. Cedric Ziel commented on patch set 5 12/15/15, 12:57

    Published edit on patch set 4
  2. Cedric Ziel voted on patch set 4 CR +1 12/15/15, 12:58

  3. Cedric Ziel voted on patch set 5 CR +1 12/15/15, 12:59

  4. Mathias Schreiber commented on patch set 5 12/21/15, 15:01

    PdoFileBackend.php:194

    c'mon!
  5. Andreas Kienast commented on patch set 6 12/21/15, 15:04

    Published edit on patch set 5
  6. Mathias Schreiber voted on patch set 6 CR +1 V +1 03/06/16, 00:51

  7. Frank Nägler commented on patch set 6 CR -1 03/07/16, 11:47

    wrong temp directory, will push an update
  8. Frank Nägler uploaded patch set 7 03/07/16, 11:55

  9. Frank Nägler commented on patch set 7 03/07/16, 11:56

    changed the cache directory and some CGL stuff
  10. Frank Nägler voted on patch set 7 CR +1 03/07/16, 11:56

  11. Wouter Wolters commented on patch set 7 CR -1 03/07/16, 12:37

    PdoFileBackend.php:100

    int

    PdoFileBackend.php:125

    missing phpdoc

    PdoFileBackend.php:134

    lowercase variable?

    PdoFileBackend.php:166

    FLOW3 ???

    PdoFileBackend.php:223

    use short version

    PdoFileBackend.php:226

    use short version

    PdoFileBackend.php:228

    exception number already in use

    PdoFileBackend.php:588

    missing phpdoc

    PdoFileBackend.php:745

    missing type
  12. Frank Nägler uploaded patch set 8 03/07/16, 13:08

  13. Frank Nägler uploaded patch set 9 03/07/16, 13:09

  14. Frank Nägler voted on patch set 9 CR +1 V +1 03/07/16, 13:09

  15. Wouter Wolters commented on patch set 9 03/07/16, 13:10

    PdoFileBackend.php:231

    phpstorm has a bug here, this timestamp is somewhere in 48151
  16. Frank Nägler uploaded patch set 10 03/07/16, 13:22

  17. Frank Nägler voted on patch set 10 CR +1 V +1 03/07/16, 13:22

  18. Wouter Wolters voted on patch set 10 CR +1 03/07/16, 13:27

  19. Christian Kuhn commented on patch set 10 CR -1 03/31/16, 20:46

    talked with morton about this one: we think it would be more cool if we redo this patch after the doctrine main integration is done and to base the database part on the new doctrine configuration and table mapping stuff. so, let's please finish this one after doctrine main steps are done.

    PdoFileBackend.php:26

    lets not extend from SimpleFileBackend here anymore.
  20. Christian Kuhn commented on patch set 10 03/31/16, 20:48

    apart from that i was convinced by xavier, tymek and morton that such a backend can actually might make sense in specific use cases ;)
  21. Andreas Kienast uploaded patch set 11 04/30/16, 14:48

  22. Andreas Kienast commented on patch set 11 CR -1 04/30/16, 14:49

    Doctrine part is still missing
  23. TYPO3com voted on patch set 11 V -1 12/04/16, 11:17 Completed build in 26m 42s on Sun, 4 Dec, 12:17 PM Test Summary: 54412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5473

  24. Benni Mack commented on patch set 11 04/21/17, 13:37

    this could happen now, right? Otherwise, we could also do this by supporting a 2nd level cache concept (so I could combine apcu+db for some cases, or apcu+memcached)
  25. Andreas Kienast abandoned the change 07/31/17, 12:59

    The project that could have taken use of this patch does not exist anymore.