Review main Merged

43327[TASK] Optimizing ElementHistoryController

Michael Oehlhof CR +2 V +2 Easy +4 −4 updated 09/15/15, 17:09

Commit message

The function getButtons() has instantiated the class RecordHistory only
for getting the returnUrl parameter.
This is replaced by GeneralUtility::_GP() and
GeneralUtility::sanitizeLocalUrl()

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 5

  1. Michael Oehlhof uploaded patch set 1 09/15/15, 12:25

  2. Wouter Wolters voted on patch set 1 CR +1 09/15/15, 12:26

  3. Nicole Hummel voted on patch set 1 CR +1 V +1 09/15/15, 16:42

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 09/15/15, 17:09

  5. Wouter Wolters merged patch set 1 09/15/15, 17:09