Review main Merged

43328[TASK] Replace editOnClick() with getModuleUrl

Benni Mack CR +2 V +2 Normal +141 −61 updated 09/16/15, 19:38

Commit message

The editOnClick produces JS which is not needed in most cases.

Using BackendUtility::getModuleUrl() allows to avoid inline JS code.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Georg Ringer +1
  • Verified V +2
    • Anja Leichsenring +2
    • Georg Ringer +1

Issues 1

Files 5

Review log 9

  1. Benni Mack uploaded patch set 1 09/15/15, 12:29

  2. Benni Mack commented on patch set 1 09/15/15, 12:31

    This is a first one, anyone can pick that task up and replace even more occurences, where possible.
  3. Wouter Wolters updated the commit message in patch set 2 09/15/15, 13:16

  4. Wouter Wolters voted on patch set 2 CR +1 09/15/15, 13:17

  5. Benni Mack uploaded patch set 3 09/16/15, 07:13

  6. Georg Ringer voted on patch set 3 CR +1 V +1 09/16/15, 07:22

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 09/16/15, 19:28

  8. Anja Leichsenring voted on patch set 3 CR +2 V +2 09/16/15, 19:30

  9. Anja Leichsenring merged patch set 3 09/16/15, 19:38