Review main Merged

43334[TASK] Use binary notation for JsConfirmation values

Mathias Brodala CR +2 V +2 Easy +5 −5 updated 09/23/15, 13:25

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Stefan Froemken +1
  • Verified V +2
    • Andreas Kienast +2
    • Stefan Froemken +1

Issues 1

Files 1

Review log 6

  1. Mathias Brodala uploaded patch set 1 09/15/15, 13:52

  2. Nicole Hummel commented on patch set 1 09/15/15, 16:52

    TBH for me this isn't really more readable
  3. Mathias Brodala commented on patch set 1 09/18/15, 07:25

    The idea was to make it easier to understand the binary check peformed in BackendUserAuthentication.
  4. Stefan Froemken commented on patch set 1 CR +1 V +1 09/21/15, 10:22

    The variables and documentation talks about bitmask and that is 0 and 1 and not decimal. So for me it's OK.
  5. Andreas Kienast voted on patch set 1 CR +2 V +2 09/23/15, 13:25

  6. Andreas Kienast merged patch set 1 09/23/15, 13:25