Review main Merged

43343[BUGFIX] Do not drop selection from "singlebox" select

Mathias Brodala CR +2 V +2 Easy +1 −1 updated 09/16/15, 20:04

Commit message

By setting the new value after validation via attribute, we avoid
triggering a new "change" event which in turn causes a validation
again.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Nicole Hummel +1
    • Thorsten Bringewatt +1
  • Verified V +2
    • Frank Nägler +2
    • Nicole Hummel +1
    • Thorsten Bringewatt +1

Issues 1

Files 1

Review log 10

  1. Mathias Brodala uploaded patch set 1 09/15/15, 15:11

  2. Nicole Hummel voted on patch set 1 CR +1 V +1 09/15/15, 16:48

  3. Wouter Wolters commented on patch set 1 CR -1 09/15/15, 17:03

    FormEngineValidation.js:493

    single qiuotes
  4. Mathias Brodala uploaded patch set 2 09/16/15, 07:57

  5. Nicole Hummel voted on patch set 2 CR +1 V +1 09/16/15, 07:59

  6. Thorsten Bringewatt voted on patch set 2 CR +1 V +1 09/16/15, 09:29

  7. Christian Kuhn commented on patch set 2 09/16/15, 19:57

    i pinged frank and hope for his feedback.
  8. Frank Nägler commented on patch set 2 CR +1 09/16/15, 19:59

    will test it now
  9. Frank Nägler voted on patch set 2 CR +2 V +2 09/16/15, 20:04

  10. Frank Nägler merged patch set 2 09/16/15, 20:04