Review main Merged

43367[BUGFIX] Fix rendering with empty date

Oliver Thiele CR +2 V +2 Easy +29 −3 updated 09/16/15, 12:57

Commit message

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Anja Leichsenring +1
    • Jan Helke +1
    • Morton Jonuschat +1
    • Oliver Thiele +1
  • Verified V +2
    • Nicole Hummel +2
    • Anja Leichsenring +1
    • Jan Helke +1
    • Morton Jonuschat +1
    • Oliver Thiele +1

Issues 1

Files 2

Review log 16

  1. Oliver Thiele uploaded patch set 1 09/16/15, 08:18

  2. Mathias Brodala uploaded patch set 2 09/16/15, 08:37

  3. Nicole Hummel commented on patch set 2 CR -1 09/16/15, 09:10

    I went back to 4.5 and can't find a way where an empty string is converted to current date. So this patch introduces a behavior change and cannot be backported. And we need a rst file here as well to document the change
  4. Oliver Thiele uploaded patch set 3 09/16/15, 12:09

  5. Anja Leichsenring voted on patch set 3 CR +1 V +1 09/16/15, 12:29

  6. Jan Helke voted on patch set 3 CR +1 V +1 09/16/15, 12:36

  7. Morton Jonuschat voted on patch set 3 CR +1 V +1 09/16/15, 12:39

  8. Anja Leichsenring commented on patch set 3 09/16/15, 12:51

    This fixes a bug introduced by the implementation of the compilable Interface. Therefor we don't target the to 6.2, but to master only.
  9. Anja Leichsenring updated the commit message in patch set 4 09/16/15, 12:52

  10. Anja Leichsenring uploaded patch set 5 09/16/15, 12:53

  11. Anja Leichsenring voted on patch set 5 CR +1 V +1 09/16/15, 12:53

  12. Morton Jonuschat voted on patch set 5 CR +1 V +1 09/16/15, 12:53

  13. Jan Helke voted on patch set 5 CR +1 V +1 09/16/15, 12:56

  14. Nicole Hummel voted on patch set 5 CR +2 V +2 09/16/15, 12:56

  15. Oliver Thiele voted on patch set 5 CR +1 V +1 09/16/15, 12:56

  16. Nicole Hummel merged patch set 5 09/16/15, 12:57