Review main Merged

43371[TASK] Add sane defaults for tracking tools to prevent 404s on cash errors

Mathias Schreiber CR +2 V +2 Easy +1 −1 updated 09/16/15, 12:43

Commit message

The usual suspects google, Facebook and twitter add get parameters to
links once shared.
If you are running a well configured TYPO3 site, cHash mismatches will
return an error 404 which we want to prevent by supplying default settings

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Nicole Hummel +1
  • Verified V +2
    • Andreas Kienast +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 7

  1. Mathias Schreiber uploaded patch set 1 09/16/15, 09:25

  2. Mathias Schreiber updated the commit message in patch set 2 09/16/15, 09:26

  3. Nicole Hummel voted on patch set 2 CR +1 V +1 09/16/15, 09:27

  4. Andreas Kienast voted on patch set 2 CR +2 V +2 09/16/15, 09:28

  5. Andreas Kienast merged patch set 2 09/16/15, 09:28

  6. Nicole Hummel commented on patch set 2 09/16/15, 09:36

    Should we add et_url for etracker as well?
  7. Markus Klein commented on patch set 3 09/16/15, 12:43

    *lol*