Review main Merged

43375[FEATURE] Allow PSR-7 dispatching for Backend modules

Benni Mack CR +2 V +2 Hard +346 −297 updated 09/18/15, 09:19

Commit message

The newly introduced simple dispatcher handles the distribution
of all "traditional" modules through a new option called "routeTarget" when registering a module.

All existing core modules are moved to this new syntax, all left-over
index.php files within Modules/ directories are removed.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Anja Leichsenring +1

Issues 1

Files 35

Show 15 more files

Review log 23

  1. Benni Mack uploaded patch set 1 09/16/15, 12:50

  2. Benni Mack commented on patch set 1 CR -1 09/16/15, 13:49

    does not evaluate the access rights currently...
  3. Benni Mack uploaded patch set 2 09/16/15, 15:14

  4. Benni Mack uploaded patch set 3 09/16/15, 16:13

  5. Benni Mack commented on patch set 3 CR -1 09/16/15, 19:34

    I'm thinking of changing the key of the module registration - using modules. will think of a solution.
  6. Benni Mack uploaded patch set 4 09/17/15, 07:06

  7. Mathias Schreiber commented on patch set 4 V -1 09/17/15, 12:34

    tstemplate sends me into BE user settings.
  8. Andreas Kienast uploaded patch set 5 09/17/15, 12:45

  9. Benni Mack uploaded patch set 6 09/17/15, 13:08

  10. Mathias Schreiber voted on patch set 6 CR +1 V +1 09/17/15, 13:14

  11. Andreas Kienast uploaded patch set 7 09/17/15, 14:20

  12. Andreas Kienast voted on patch set 7 CR +1 V +1 09/17/15, 14:20

  13. Mathias Schreiber voted on patch set 7 CR +1 V +1 09/17/15, 14:21

  14. Wouter Wolters voted on patch set 7 CR +1 09/17/15, 16:59

  15. Wouter Wolters commented on patch set 7 V -1 CR -1 09/17/15, 19:39

    This leads to broken styling for at least ext:lowlevel Configuration module. The module name that gets an generated id on the body change now.
  16. Wouter Wolters uploaded patch set 8 09/17/15, 19:42

  17. Wouter Wolters commented on patch set 8 V +1 CR +1 09/17/15, 19:43

    Solved the styling issue in lowlevel. Looks like the only affected module with this change.
  18. Anja Leichsenring voted on patch set 8 CR +1 V +1 09/17/15, 20:26

  19. Markus Klein commented on patch set 8 09/17/15, 21:02

    Doesn't that one also need a breaking rst for the removed files? I also propose to kick all those printContent() methods in one go as the index.php files removals are already breaking.
  20. Benni Mack commented on patch set 8 09/18/15, 06:14

    Hey Markus, I consider deprecating the "PATH" way of registering modules at a later / separate patch. If you want to remove the printContent() there, I think let's do it then, OK?
  21. Markus Klein commented on patch set 8 CR +1 09/18/15, 09:17

    Talked it through with Benni. Go ahead
  22. Benni Mack voted on patch set 8 CR +2 V +2 09/18/15, 09:19

  23. Benni Mack merged patch set 8 09/18/15, 09:19