43375[FEATURE] Allow PSR-7 dispatching for Backend modules
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Wouter Wolters +1
- Markus Klein +1
- Anja Leichsenring +1
-
Verified V +2
- Benni Mack +2
- Wouter Wolters +1
- Anja Leichsenring +1
Issues 1
Files 35
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+21 −0
- typo3/sysext/backend/Classes/Http/BackendModuleRequestHandler.php+24 −13
- typo3/sysext/backend/Classes/Module/ModuleLoader.php+2 −1
- typo3/sysext/backend/Modules/Layout/index.phpdeleted+0 −19
- typo3/sysext/backend/ext_tables.php+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-69918-AddPSR-7-basedDispatchingForBackendModules.rstnew+34 −0
- typo3/sysext/dbal/Classes/Controller/ModuleController.php+29 −7
- typo3/sysext/dbal/Modules/Dbal/index.phpdeleted+0 −22
- typo3/sysext/dbal/ext_tables.php+2 −2
- typo3/sysext/func/Classes/Controller/PageFunctionsController.php+27 −0
- typo3/sysext/func/Modules/AdvancedFunctions/index.phpdeleted+0 −30
- typo3/sysext/func/ext_tables.php+2 −2
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+28 −0
- typo3/sysext/info/Modules/Info/index.phpdeleted+0 −28
- typo3/sysext/info/ext_tables.php+2 −2
- typo3/sysext/lowlevel/Classes/View/ConfigurationView.php+23 −0
- typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php+21 −0
- typo3/sysext/lowlevel/Modules/Configuration/index.phpdeleted+0 −24
- typo3/sysext/lowlevel/Modules/DatabaseIntegrity/index.phpdeleted+0 −24
- typo3/sysext/lowlevel/ext_tables.php+4 −4
Show 15 more files
- typo3/sysext/recordlist/Classes/RecordList.php+23 −0
- typo3/sysext/recordlist/Modules/Recordlist/index.phpdeleted+0 −30
- typo3/sysext/recordlist/ext_tables.php+2 −2
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+21 −0
- typo3/sysext/scheduler/Modules/Scheduler/index.phpdeleted+0 −18
- typo3/sysext/scheduler/ext_tables.php+2 −2
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+24 −0
- typo3/sysext/setup/Modules/Setup/index.phpdeleted+0 −20
- typo3/sysext/setup/ext_tables.php+2 −2
- typo3/sysext/taskcenter/Classes/Controller/TaskModuleController.php+19 −0
- typo3/sysext/taskcenter/Modules/Taskcenter/index.phpdeleted+0 −17
- typo3/sysext/taskcenter/ext_tables.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+28 −0
- typo3/sysext/tstemplate/Modules/TsTemplate/index.phpdeleted+0 −22
- typo3/sysext/tstemplate/ext_tables.php+2 −2
Review log 23
-
Benni Mack uploaded patch set 1 09/16/15, 12:50
-
Benni Mack commented on patch set 1 CR -1 09/16/15, 13:49
does not evaluate the access rights currently... -
Benni Mack uploaded patch set 2 09/16/15, 15:14
-
Benni Mack uploaded patch set 3 09/16/15, 16:13
-
Benni Mack commented on patch set 3 CR -1 09/16/15, 19:34
I'm thinking of changing the key of the module registration - using modules. will think of a solution. -
Benni Mack uploaded patch set 4 09/17/15, 07:06
-
Mathias Schreiber commented on patch set 4 V -1 09/17/15, 12:34
tstemplate sends me into BE user settings. -
Andreas Kienast uploaded patch set 5 09/17/15, 12:45
-
Benni Mack uploaded patch set 6 09/17/15, 13:08
-
Mathias Schreiber voted on patch set 6 CR +1 V +1 09/17/15, 13:14
-
Andreas Kienast uploaded patch set 7 09/17/15, 14:20
-
Andreas Kienast voted on patch set 7 CR +1 V +1 09/17/15, 14:20
-
Mathias Schreiber voted on patch set 7 CR +1 V +1 09/17/15, 14:21
-
Wouter Wolters voted on patch set 7 CR +1 09/17/15, 16:59
-
Wouter Wolters commented on patch set 7 V -1 CR -1 09/17/15, 19:39
This leads to broken styling for at least ext:lowlevel Configuration module. The module name that gets an generated id on the body change now. -
Wouter Wolters uploaded patch set 8 09/17/15, 19:42
-
Wouter Wolters commented on patch set 8 V +1 CR +1 09/17/15, 19:43
Solved the styling issue in lowlevel. Looks like the only affected module with this change. -
Anja Leichsenring voted on patch set 8 CR +1 V +1 09/17/15, 20:26
-
Markus Klein commented on patch set 8 09/17/15, 21:02
Doesn't that one also need a breaking rst for the removed files? I also propose to kick all those printContent() methods in one go as the index.php files removals are already breaking. -
Benni Mack commented on patch set 8 09/18/15, 06:14
Hey Markus, I consider deprecating the "PATH" way of registering modules at a later / separate patch. If you want to remove the printContent() there, I think let's do it then, OK? -
Markus Klein commented on patch set 8 CR +1 09/18/15, 09:17
Talked it through with Benni. Go ahead -
Benni Mack voted on patch set 8 CR +2 V +2 09/18/15, 09:19
-
Benni Mack merged patch set 8 09/18/15, 09:19