Review main Merged

43389[BUGFIX] LocalCropScaleMaskHelper consumes too much memory when cropping

Thomas Maroschik CR +2 V +2 Easy +20 −5 updated 09/17/15, 20:51

Commit message

When using the new image crop functionality in the backend the
LocalCropScaleMaskHelper crops the image using gdlib functions. Those
functions load the whole image into memory and can lead to fatal
errors because of memory limits in case of large images.

This fix replaces the gdlib functions with according ImageMagick/
GraphicsMagick functions which crop the image outside of PHP's
memory.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Mathias Schreiber +1
    • Frans Saris +1
    • Andreas Bouche +1
  • Verified V +2
    • Anja Leichsenring +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 7

  1. Thomas Maroschik uploaded patch set 1 09/17/15, 09:45

  2. Wouter Wolters updated the commit message in patch set 2 09/17/15, 10:19

  3. Mathias Schreiber voted on patch set 2 CR +1 V +1 09/17/15, 11:05

  4. Andreas Bouche voted on patch set 2 CR +1 09/17/15, 11:53

  5. Frans Saris voted on patch set 2 CR +1 09/17/15, 13:02

  6. Anja Leichsenring voted on patch set 2 CR +2 V +2 09/17/15, 20:51

  7. Anja Leichsenring merged patch set 2 09/17/15, 20:51