43414[TASK] Update datepicker.js, moment.js and add moment-timezone.js
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Benni Mack +2
- Wouter Wolters +1
-
Verified V +2
- Andreas Kienast +2
- Benni Mack +1
Issues 1
Files 6
- Build/bower.json2+3 −2
- Build/Gruntfile.js2+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap-datetimepicker.js+3 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/moment-timezone.jsnew+7 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/moment.js+2 −2
- typo3/sysext/t3skin/Resources/Public/Css/backend.css+9 −2
Review log 19
-
Tymoteusz Motylewski uploaded patch set 1 09/18/15, 09:14
-
Tymoteusz Motylewski uploaded patch set 2 09/18/15, 09:15
-
Tymoteusz Motylewski updated the commit message in patch set 3 09/18/15, 09:19
-
Andreas Kienast commented on patch set 3 09/18/15, 09:22
-
Wouter Wolters commented on patch set 3 09/18/15, 09:23
Gruntfile.js:110and maybe uglify the new js file too? -
Tymoteusz Motylewski uploaded patch set 4 09/18/15, 10:22
-
Tymoteusz Motylewski commented on patch set 3 09/18/15, 10:22
Gruntfile.js:110ReplyIt's aready minified. Do you think we should uglify it anyway? -
Tymoteusz Motylewski commented on patch set 3 09/18/15, 10:22
bower.json:34ReplyDone -
Morton Jonuschat commented on patch set 4 CR +1 V +1 09/18/15, 12:19
Don't think uglifying an already minified file has any benefit. -
Wouter Wolters voted on patch set 4 CR +1 09/18/15, 12:21
-
Morton Jonuschat commented on patch set 4 09/18/15, 12:22
Backend & Datepicker work fine, but maybe you should update the backend.css to include the upstream changes from bootstrap-datepicker. -
Tymoteusz Motylewski uploaded patch set 5 09/18/15, 13:13
-
Tymoteusz Motylewski commented on patch set 5 09/18/15, 13:15
Thanks Morton, good catch. I've uploaded new version with css changes -
Wouter Wolters voted on patch set 5 CR +1 09/18/15, 13:27
-
Benni Mack voted on patch set 5 CR +2 V +1 09/18/15, 14:25
-
Andreas Kienast commented on patch set 5 V -1 09/18/15, 14:50
The time selector is below the calendar view. -
Andreas Kienast commented on patch set 5 CR +2 V +2 09/18/15, 15:19
Was a local issue, the right frame was too small for the interal change to col-md-6 -
Andreas Kienast merged patch set 5 09/18/15, 15:19
-
Tymoteusz Motylewski commented on patch set 6 09/18/15, 15:20
Thanks guys!
bower.json:34