Review main Merged

43414[TASK] Update datepicker.js, moment.js and add moment-timezone.js

Tymoteusz Motylewski CR +2 V +2 Easy +25 −8 updated 09/18/15, 15:20

Commit message

This is required as a groundwork before introducing timezone
handling in backend date fields.
Since version "4.17.37" eonasdan-bootstrap-datetimepicker
supports timezones.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Benni Mack +1

Issues 1

Files 6

Review log 19

  1. Tymoteusz Motylewski uploaded patch set 1 09/18/15, 09:14

  2. Tymoteusz Motylewski uploaded patch set 2 09/18/15, 09:15

  3. Tymoteusz Motylewski updated the commit message in patch set 3 09/18/15, 09:19

  4. Andreas Kienast commented on patch set 3 09/18/15, 09:22

    bower.json:34

    shouldn't we update moment to 2.10.6 to avoid possible conflict with those other libs?
  5. Wouter Wolters commented on patch set 3 09/18/15, 09:23

    Gruntfile.js:110

    and maybe uglify the new js file too?
  6. Tymoteusz Motylewski uploaded patch set 4 09/18/15, 10:22

  7. Tymoteusz Motylewski commented on patch set 3 09/18/15, 10:22

    Gruntfile.js:110 Reply

    It's aready minified. Do you think we should uglify it anyway?
  8. Tymoteusz Motylewski commented on patch set 3 09/18/15, 10:22

    bower.json:34 Reply

    Done
  9. Morton Jonuschat commented on patch set 4 CR +1 V +1 09/18/15, 12:19

    Don't think uglifying an already minified file has any benefit.
  10. Wouter Wolters voted on patch set 4 CR +1 09/18/15, 12:21

  11. Morton Jonuschat commented on patch set 4 09/18/15, 12:22

    Backend & Datepicker work fine, but maybe you should update the backend.css to include the upstream changes from bootstrap-datepicker.
  12. Tymoteusz Motylewski uploaded patch set 5 09/18/15, 13:13

  13. Tymoteusz Motylewski commented on patch set 5 09/18/15, 13:15

    Thanks Morton, good catch. I've uploaded new version with css changes
  14. Wouter Wolters voted on patch set 5 CR +1 09/18/15, 13:27

  15. Benni Mack voted on patch set 5 CR +2 V +1 09/18/15, 14:25

  16. Andreas Kienast commented on patch set 5 V -1 09/18/15, 14:50

    The time selector is below the calendar view.
  17. Andreas Kienast commented on patch set 5 CR +2 V +2 09/18/15, 15:19

    Was a local issue, the right frame was too small for the interal change to col-md-6
  18. Andreas Kienast merged patch set 5 09/18/15, 15:19

  19. Tymoteusz Motylewski commented on patch set 6 09/18/15, 15:20

    Thanks guys!