43416[TASK] Replace onclick with href URLs in PagePositionMap
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 13
-
Benni Mack uploaded patch set 1 09/18/15, 10:42
-
Michael Oehlhof commented on patch set 1 V -1 09/19/15, 00:04
After Save&Close of a new page the page was created but then an error occurs instead of displaying the newly created page: The requested URL /typo3//typo3/index.php?M=web_list&moduleToken=dbe471a05121ce2371dfdfe009f102819dbe6a5e&id=2&imagemode=1&id=23 was not found on this server. id=23 is the id of the newly created page -
Benni Mack updated the commit message in patch set 2 09/30/15, 16:51
-
Benni Mack uploaded patch set 3 09/30/15, 17:03
-
Wouter Wolters voted on patch set 3 V +1 CR +1 09/30/15, 17:28
-
Markus Klein commented on patch set 3 09/30/15, 17:47
PagePositionMap.php:254Are we sure this is NOT -1? Does it always have a value? Otherwise we miss the fallback to getIndpEnv('REQUEST_URI') -
Michael Oehlhof voted on patch set 3 CR +1 V +1 09/30/15, 18:42
-
Benni Mack commented on patch set 3 09/30/15, 20:43
PagePositionMap.php:254Replyhmm, good point. -1 is only set in the list module (and I want to kill that too :)). Will tackle that before then - makes more sense. RequestUri additions seems logical! -
Michael Oehlhof uploaded patch set 4 09/30/15, 22:57
-
Markus Klein commented on patch set 4 CR -1 10/01/15, 16:25
-1 and empty value handling missing as commented before -
Oliver Hader uploaded patch set 5 10/09/15, 00:12
-
Stefan Neufeind commented on patch set 5 CR -1 10/18/15, 20:00
the -1 from Markus still seems to count (some parts missing) -
Benni Mack abandoned the change 12/04/15, 23:17
Abandoned for now - won't work until we really rewrite PagePositionMap stuff in v8.