Review main Merged

43453[BUGFIX] Remove button group in image-cropper

Boris Schauer CR +2 V +2 Easy +10 −2 updated 10/27/15, 20:33

Commit message

If labels on the crop buttons are too long or if there are more
buttons then the btn-group breaks the view.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Andreas Bouche +1
  • Verified V +2
    • Stefan Neufeind +2
    • Andreas Bouche +1

Issues 1

Files 3

Review log 12

  1. Boris Schauer uploaded patch set 1 09/21/15, 09:51

  2. Wouter Wolters commented on patch set 1 CR -1 09/21/15, 09:55

    Boris, thanks for the patch, but "t3js-" is a prefix for JavaScript usage only. Do not use these classes in CSS please.
  3. Mathias Schreiber updated the commit message in patch set 2 09/21/15, 10:00

  4. Boris Schauer uploaded patch set 3 09/21/15, 10:14

  5. Boris Schauer uploaded patch set 4 09/21/15, 10:24

  6. Boris Schauer uploaded patch set 5 09/21/15, 10:47

  7. Michael Stucki uploaded patch set 6 09/21/15, 16:10

  8. Stefan Neufeind uploaded patch set 7 10/23/15, 13:24

  9. Stefan Neufeind commented on patch set 7 CR +1 10/23/15, 13:25

    tiny cleanups (whitespace)
  10. Andreas Bouche voted on patch set 7 CR +1 V +1 10/27/15, 12:59

  11. Stefan Neufeind voted on patch set 7 CR +2 V +2 10/27/15, 20:33

  12. Stefan Neufeind merged patch set 7 10/27/15, 20:33