Review main Abandoned

43456[FEATURE] Introduce PdoFileBackend

Andreas Kienast CR 0 V 0 Expert +1050 −0 updated 10/05/15, 14:05

Commit message

Introduce a PdoFileBackend which is a hybrid of PdoBackend and FileBackend.
The advantage of such new backend is, it reduces the I/O on the disk when
purging caches, which heavily increases the disk performance for very large
(> 30,000) caches. It also decreases the I/O on cache lookup per cache file due
to the lookup of the cache info in database.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 5

  1. Andreas Kienast uploaded patch set 1 09/21/15, 14:04

  2. Andreas Kienast abandoned the change 09/22/15, 12:10

    Old patch was recovered
  3. Frank Nägler commented on patch set 1 10/02/15, 09:32

    Feature-69824-IntroducedPdoFileBackend.rst:28

    is it a good idea to store the cache within the DocumentRoot? The cache could contain sensitive informations. I would prefer to add another example here and maybe prevent usage of directories within the DocumentRoot!?
  4. Frank Nägler commented on patch set 1 10/05/15, 10:41

    PdoFileBackend.php:247

    $data is a string, imo no serialize needed here.

    PdoFileBackend.php:247

    $tags is an array of strings, and serialize is expensive. for hash building md5(json_encode()) should work also and has a better performance.

    PdoFileBackend.php:336

    not sure here: but are double quotes ok for field names?

    PdoFileBackend.php:450

    maybe use trimExplode here?

    PdoFileBackend.php:563

    we have the same check in SimpleFileBackend, would it make sense to centralize this code?
  5. Andreas Kienast commented on patch set 1 10/05/15, 14:05

    Will push a new patch set. Please move to the old and restored patch :) https://review.typo3.org/#/c/43326/

    PdoFileBackend.php:336 Reply

    That's some PDO-related stuff, it's also done in PdoBackend.php

    PdoFileBackend.php:450 Reply

    I don't think it's required, one passes the dataSourceName in LocalConfiguration.php.