43460[FEATURE] Make it possible to register own icons for file extensions
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2
- Frank Nägler +2
- Christian Kuhn +1
- Andreas Kienast +1
Issues 1
Files 4
- typo3/sysext/core/Classes/Imaging/IconFactory.php+4 −92
- typo3/sysext/core/Classes/Imaging/IconRegistry.php2+99 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-70002-MakeItPossibleToRegisterOwnIconsForFileExtensions.rst4new+19 −0
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+43 −0
Review log 17
-
Frank Nägler uploaded patch set 1 09/21/15, 17:50
-
Frank Nägler voted on patch set 1 CR -2 09/21/15, 17:51
-
Frank Nägler updated the commit message in patch set 2 09/22/15, 07:46
-
Frank Nägler voted on patch set 2 CR 0 09/22/15, 16:09
-
Christian Kuhn commented on patch set 2 09/22/15, 18:53
-
Daniel Goerz commented on patch set 2 09/22/15, 19:00
IconRegistry.php:1852no empty line hereFeature-70002-MakeItPossibleToRegisterOwnIconsForFileExtensions.rst:8"for a file extension" or "for file extensions" -
Frank Nägler commented on patch set 2 09/22/15, 20:30
push a new setIconRegistry.php:1852ReplyDoneFeature-70002-MakeItPossibleToRegisterOwnIconsForFileExtensions.rst:8ReplyDoneFeature-70002-MakeItPossibleToRegisterOwnIconsForFileExtensions.rst:8ReplyDone -
Frank Nägler uploaded patch set 3 09/22/15, 20:30
-
Frank Nägler uploaded patch set 4 09/22/15, 20:30
-
Frank Nägler uploaded patch set 5 09/22/15, 21:06
-
Christian Kuhn voted on patch set 5 CR +1 V +1 09/23/15, 11:48
-
Andreas Kienast updated the commit message in patch set 6 09/23/15, 11:51
-
Andreas Kienast commented on patch set 6 CR +1 V +1 09/23/15, 11:53
Verified by unit tests -
Christian Kuhn voted on patch set 6 CR +1 V +1 09/23/15, 11:55
-
Frank Nägler voted on patch set 6 CR +2 V +2 09/23/15, 12:05
-
Frank Nägler merged patch set 6 09/23/15, 12:05
-
Stephan Großberndt commented on patch set 7 09/23/15, 12:19
POST +1 :-)
Feature-70002-MakeItPossibleToRegisterOwnIconsForFileExtensions.rst:8