Review main Merged

43460[FEATURE] Make it possible to register own icons for file extensions

Frank Nägler CR +2 V +2 Hard +165 −92 updated 09/23/15, 12:19

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1
    • Andreas Kienast +1

Issues 1

Files 4

Review log 17

  1. Frank Nägler uploaded patch set 1 09/21/15, 17:50

  2. Frank Nägler voted on patch set 1 CR -2 09/21/15, 17:51

  3. Frank Nägler updated the commit message in patch set 2 09/22/15, 07:46

  4. Frank Nägler voted on patch set 2 CR 0 09/22/15, 16:09

  5. Christian Kuhn commented on patch set 2 09/22/15, 18:53

    Feature-70002-MakeItPossibleToRegisterOwnIconsForFileExtensions.rst:8

    "makes" ... or better "The IconRegistry has been extented with a mapping of file extensions no icons" or something similar.
  6. Daniel Goerz commented on patch set 2 09/22/15, 19:00

    IconRegistry.php:1852

    no empty line here

    Feature-70002-MakeItPossibleToRegisterOwnIconsForFileExtensions.rst:8

    "for a file extension" or "for file extensions"
  7. Frank Nägler commented on patch set 2 09/22/15, 20:30

    push a new set

    IconRegistry.php:1852 Reply

    Done

    Feature-70002-MakeItPossibleToRegisterOwnIconsForFileExtensions.rst:8 Reply

    Done

    Feature-70002-MakeItPossibleToRegisterOwnIconsForFileExtensions.rst:8 Reply

    Done
  8. Frank Nägler uploaded patch set 3 09/22/15, 20:30

  9. Frank Nägler uploaded patch set 4 09/22/15, 20:30

  10. Frank Nägler uploaded patch set 5 09/22/15, 21:06

  11. Christian Kuhn voted on patch set 5 CR +1 V +1 09/23/15, 11:48

  12. Andreas Kienast updated the commit message in patch set 6 09/23/15, 11:51

  13. Andreas Kienast commented on patch set 6 CR +1 V +1 09/23/15, 11:53

    Verified by unit tests
  14. Christian Kuhn voted on patch set 6 CR +1 V +1 09/23/15, 11:55

  15. Frank Nägler voted on patch set 6 CR +2 V +2 09/23/15, 12:05

  16. Frank Nägler merged patch set 6 09/23/15, 12:05

  17. Stephan Großberndt commented on patch set 7 09/23/15, 12:19

    POST +1 :-)