43475[BUGFIX] EXT:form - avoid number reduction in currency filter
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Björn Jacob +1
- Christian Kuhn +1
-
Verified V +2
- Stefan Neufeind +2
- Björn Jacob +1
- Christian Kuhn +1
Issues 1
Files 2
Review log 18
-
Ralf Zimmermann uploaded patch set 1 09/22/15, 13:16
-
Björn Jacob updated the commit message in patch set 2 09/24/15, 08:10
-
Björn Jacob commented on patch set 2 CR +1 V +1 09/24/15, 14:16
Works like a charm and looks good to me. Tested with "34567890". Stays after several submits "34.567.890,00". -
Jan Helke voted on patch set 2 V +1 CR +1 09/25/15, 11:17
-
Jan Helke commented on patch set 2 V -1 CR -1 09/25/15, 11:20
Sorry. Unit Tests are failing -
Morton Jonuschat commented on patch set 2 CR -1 V -1 09/25/15, 11:49
CurrencyFilter.php:91This removes the decimal point of your input value, turning 3333.33 into 333333. Depending on the setting of thousandSeparator and decimalsPoint there are other Gremlins in the whole filter() code... -
Björn Jacob commented on patch set 2 V -1 09/25/15, 11:56
We should extend the unit tests. Testing for the different values possible depending on the decimal point and thousand seperator settings. -
Jan Helke commented on patch set 2 09/25/15, 14:38
I don't see the need to change the unit tests in the first place. Given the example, the user tries to enter the number "3333.33", I would expect, that the filter converts it to "3,333.33". But that results with this patch is 333,333.00. -
Oliver Hader uploaded patch set 3 10/09/15, 00:20
-
Morton Jonuschat commented on patch set 3 CR +1 V +1 10/09/15, 06:08
Restore votes.. -
Morton Jonuschat voted on patch set 3 CR -1 V -1 10/09/15, 06:09
-
Daniel L uploaded patch set 4 10/20/15, 13:34
-
Daniel L commented on patch set 4 10/20/15, 13:40
Special cases of localized input formats are not covered yet. For example: if the configuration for thousand seperator is set to "." than inputs like 12.00 will result in 1.200,00 not in 12,00. The position of "." on the input has no special meaning. -
Stefan Neufeind commented on patch set 4 CR +1 10/25/15, 19:13
@Daniel: What would be an expected behaviour for a thousandy-separator and input of 12.00? 12000? imho leaving out the thousands-separator for numerical interpretation is okay. The case described in the issue was that upon each subsequent save the (wrong) interpretation was done again, leading to changing results. -
Christian Kuhn voted on patch set 4 CR +1 V +1 10/25/15, 20:02
-
Björn Jacob commented on patch set 4 CR +1 V +1 10/25/15, 20:52
Tested with supplied example in issue. Also ran unit tests. Everything is fine. Just added example form to issue for faster testing. -
Stefan Neufeind commented on patch set 4 V +2 CR +2 10/25/15, 22:15
Discussed his remark with Daniel Lorenz. Doing more "magic" would definitely be out-of-scope for this patch. It fixes the bug. -
Stefan Neufeind merged patch set 4 10/25/15, 22:15