43486[BUGFIX] Make t3editor save data again
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2
- Georg Ringer +2
- Christian Kuhn +1
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/File/EditFileController.php1+2 −2
- typo3/sysext/t3editor/Resources/Public/JavaScript/FileEdit.js+29 −24
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+3 −3
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+4 −4
Review log 22
-
Wouter Wolters uploaded patch set 1 09/22/15, 20:48
-
Stefan Froemken commented on patch set 1 V -1 09/23/15, 06:21
If I press CMD+S a red panel with following error appears: "An error occurred while saving the data." AjaxUrl: /typo3/index.php?ajaxID=T3Editor::saveCode&ajaxToken=3f46d97dcd3ebe95227bd1fc1d2efba012f3f965. JSON: result: false -
Wouter Wolters uploaded patch set 2 09/23/15, 06:36
-
Stefan Froemken uploaded patch set 3 09/23/15, 06:39
-
Stefan Froemken commented on patch set 1 09/23/15, 06:39
Oh shit. Sorry -
Wouter Wolters uploaded patch set 4 09/23/15, 07:05
-
Stefan Froemken commented on patch set 4 V +1 09/23/15, 07:17
Thank you. Works now. I don't vote for code-review, because I don't understand the JS magic. We define onclick-attribute. Remove it with js, add another event and replace some parts of onclick with nothing. :confused: sorry -
Christian Kuhn commented on patch set 4 09/23/15, 10:35
testing now. -
Stefan Neufeind commented on patch set 4 V +1 09/23/15, 10:58
close, save and save-and-close work for me as expected. Could you maybe comment on why the unbinding and new binding of the event is needed? I assume we can't bind it correctly in the first place? -
Christian Kuhn commented on patch set 4 V -1 09/23/15, 11:05
file list still has one broken button, other than that my testing was successful.EditFileController.php:250save if still broken with t3editor loaded in file edit content -
Wouter Wolters commented on patch set 4 09/23/15, 11:09
That button works fine here. -
Christian Kuhn commented on patch set 4 V 0 09/23/15, 12:20
really? funny, this is reproducible broken for me: chrome - file -> filelist, "edit content" of a .txt file -> t3editor comes up -> change something -> save (not save+close) -> iframe reloads but content is not saved. i'll remove my -1 for now since this is not reproducible for me. the patch solves much more than this detail and I'd be fine to sort this out later if other people have the same issue, maybe i'm just stupid. -
Christian Kuhn commented on patch set 4 09/23/15, 12:20
typo ... reproducible for -you- ... -
Wouter Wolters commented on patch set 4 09/23/15, 12:31
Tested in chrome now, works as expected and content is saved. -
Stefan Froemken commented on patch set 4 09/23/15, 12:33
I can confirm. t3editor works like expected in filelist with Save and also CMD+S in Chrome. -
Christian Kuhn commented on patch set 4 CR +2 V +2 09/23/15, 12:39
weird. ok, let's get this in then and see if someone else reports this issue later. -
Christian Kuhn commented on patch set 4 CR 0 V 0 09/23/15, 12:40
debugging with wouter ;) -
Wouter Wolters uploaded patch set 5 09/23/15, 12:59
-
Christian Kuhn commented on patch set 5 CR +1 V +1 09/23/15, 13:02
thx wouter! -
Georg Ringer voted on patch set 5 V +2 CR +2 09/23/15, 13:09
-
Georg Ringer merged patch set 5 09/23/15, 13:09
-
Josef Glatz voted on patch set 4 CR +1 01/09/19, 20:56