43488[BUGFIX] Use proper fieldname to check result in getFirstTimeValueForRecord()
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Sascha Egerer +1
- Stefan Froemken +1
- Michael Oehlhof +1
- Helmut Hummel +1
-
Verified V +2
- Nicole Hummel +2
- Stefan Froemken +1
- Helmut Hummel +1
Issues 1
Files 1
Review log 14
-
Georg Ringer uploaded patch set 1 09/23/15, 04:52
-
Stefan Froemken commented on patch set 1 V +1 09/23/15, 08:26
You can test that with a line like that in TS: config.cache.38 = tx_sfcategory_domain_model_car:42TypoScriptFrontendController.php:4609Can we remove that line, since loadTCA isn't valid anymore?TypoScriptFrontendController.php:4616Can we change that to !== NULL? -
Georg Ringer uploaded patch set 2 09/23/15, 12:36
-
Georg Ringer commented on patch set 2 09/23/15, 12:36
i don't want to change more than needed. is_null works perfectly and is also widely used in the core -
Stefan Froemken voted on patch set 2 CR +1 V +1 09/23/15, 12:39
-
Michael Oehlhof voted on patch set 2 CR +1 09/23/15, 19:15
-
Sascha Egerer voted on patch set 2 CR +1 09/23/15, 19:21
-
Helmut Hummel voted on patch set 2 CR +2 V +2 09/23/15, 19:30
-
Helmut Hummel commented on patch set 2 CR -1 V -1 09/23/15, 19:32
wait a bit -
Nicole Hummel commented on patch set 2 09/23/15, 19:43
TypoScriptFrontendController.php:4613current timestamp -
Helmut Hummel voted on patch set 2 CR +1 V +1 09/23/15, 19:47
-
Nicole Hummel voted on patch set 2 CR +1 V +1 09/23/15, 19:47
-
Nicole Hummel voted on patch set 2 CR +2 V +2 09/23/15, 19:48
-
Nicole Hummel merged patch set 2 09/23/15, 19:48