Review TYPO3_6-2 Merged

43491[BUGFIX] EXT:form - avoid number reduction in currency filter

Ralf Zimmermann CR +2 V +2 Normal +62 −8 updated 11/13/15, 12:20

Commit message

Avoid a number reduction each time the filter is applied.
Preserve the decimal places.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Björn Jacob +1
    • Richard Haeser +1
  • Verified V +2
    • Morton Jonuschat +2
    • Björn Jacob +1

Issues 1

Files 2

Review log 9

  1. Ralf Zimmermann uploaded patch set 1 09/23/15, 07:29

  2. Ralf Zimmermann commented on patch set 1 09/23/15, 07:52

    The Version for TYPO3 7 lives here: https://review.typo3.org/#/c/43475/
  3. Oliver Hader commented on patch set 1 CR +1 09/23/15, 09:57

    Looks good, enhancing the unit test for that calling the filter twice would proof the bugfix though?
  4. Morton Jonuschat uploaded patch set 2 11/13/15, 10:38

  5. Morton Jonuschat commented on patch set 2 CR +1 V +1 11/13/15, 10:39

    Unit tests were failing for me. Backported the changes from the (merged) master branch patchset.
  6. Richard Haeser voted on patch set 2 CR +1 11/13/15, 11:40

  7. Björn Jacob commented on patch set 2 CR +1 V +1 11/13/15, 11:54

    Tested the patchset on a current 6.2 with the supplied test case. Works as expected. Thx Morton for taking care of the backport.
  8. Morton Jonuschat voted on patch set 2 CR +2 V +2 11/13/15, 12:19

  9. Gerrit merged patch set 2 11/13/15, 12:20