43492[BUGFIX] EXT:form - OPTGROUP cannot be a child element of SELECT
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Björn Jacob +1
-
Verified V +2
- Morton Jonuschat +2
- Björn Jacob +1
Issues 1
Files 1
Review log 7
-
Ralf Zimmermann uploaded patch set 1 09/23/15, 07:36
-
Oliver Hader commented on patch set 1 09/23/15, 10:04
SelectElement.php:60Use brackets for better readability -> !($element instanceof <object>) -
Ralf Zimmermann uploaded patch set 2 09/24/15, 21:44
-
Björn Jacob commented on patch set 2 V -1 11/13/15, 22:38
After applying the patch the form view does work. On the confirmation page the value of the select is not available/ visible. -
Björn Jacob commented on patch set 2 CR +1 V +1 11/26/15, 11:39
Tested with supplied example (see issue). Works as expected. Problem was that my example form had no name for the select element. -
Morton Jonuschat voted on patch set 2 CR +2 V +2 11/27/15, 16:18
-
Gerrit merged patch set 2 11/27/15, 16:18
SelectElement.php:58