43496[!!!][TASK] Resolve URLs to "Link to external URL"-pages directly
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Benni Mack +1
-
Verified V +2
- Wouter Wolters +2
- Benni Mack +1
Issues 1
Files 2
Review log 14
-
Georg Ringer uploaded patch set 1 09/23/15, 09:18
-
Markus Klein commented on patch set 1 09/23/15, 09:25
Basically I like that, but I guess this was done the other way before, to have those menu clicks in the webserver's log. So not sure if this is "breaking" for some people. -
Georg Ringer commented on patch set 1 09/23/15, 18:36
yes this was in the days where all those stuff couldnt not be tracked, now you can do all those things in e.g. GoogleAnalytics. especially on mobile & co, this is really annoying and IMO there is now no benefit anymore. @josef: we try to make the core less featureswitch-rich and just provide one good way. with TS you can still override the whole menu and add a link to the previous behaviour. -
Georg Ringer commented on patch set 1 09/23/15, 18:37
but please lets wait until stab phase is over -
Benni Mack commented on patch set 1 10/01/15, 09:07
this is breaking IMHO. What happens if you have a typolink to that page? Is it resolved directly as well? -
Markus Klein commented on patch set 1 10/01/15, 16:22
@Benni: Nothing changes in this regard. You'll still get the redirect. This is only for menu generation. -
Markus Klein voted on patch set 1 CR +1 10/01/15, 16:23
-
Benni Mack voted on patch set 1 CR +2 10/08/15, 20:32
-
Benni Mack voted on patch set 1 V +1 10/08/15, 20:49
-
Benni Mack uploaded patch set 2 10/08/15, 20:52
-
Benni Mack voted on patch set 2 CR +1 V +1 10/08/15, 20:52
-
Wouter Wolters voted on patch set 2 V +2 CR +2 10/08/15, 21:20
-
Wouter Wolters merged patch set 2 10/08/15, 21:20
-
Josef Glatz commented on patch set 1 01/09/19, 20:56
What about adding a feature switch? Globally and/or with the possibility to overwrite the global setting within TS?