Review main Merged

43498[TASK] Add disable option for Viewpage language selector

Mathias Schreiber CR +2 V +2 Easy +7 −0 updated 09/23/15, 19:43

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1

Issues 1

Files 2

Review log 17

  1. Mathias Schreiber uploaded patch set 1 09/23/15, 09:58

  2. Markus Klein updated the commit message in patch set 2 09/23/15, 10:10

  3. Markus Klein voted on patch set 2 CR +1 09/23/15, 10:11

  4. Andreas Kienast voted on patch set 2 CR +1 09/23/15, 10:28

  5. Stephan Großberndt voted on patch set 2 CR +1 09/23/15, 10:49

  6. Helmut Hummel commented on patch set 2 09/23/15, 11:53

    There is a reasoning why this option is introduced. It would be good to have this reasoning in a forge ticket and the commit message and not just do a followup. Imho
  7. Mathias Schreiber updated the commit message in patch set 3 09/23/15, 12:03

  8. Mathias Schreiber updated the commit message in patch set 4 09/23/15, 12:03

  9. Andreas Kienast voted on patch set 4 CR +1 09/23/15, 12:32

  10. Andreas Kienast uploaded patch set 5 09/23/15, 13:36

  11. Andreas Kienast voted on patch set 5 CR +1 09/23/15, 13:37

  12. Helmut Hummel voted on patch set 5 CR +1 09/23/15, 14:03

  13. Wouter Wolters voted on patch set 5 V +1 CR +1 09/23/15, 16:48

  14. Georg Ringer uploaded patch set 6 09/23/15, 19:31

  15. Georg Ringer voted on patch set 6 CR +1 V +1 09/23/15, 19:31

  16. Wouter Wolters voted on patch set 6 V +2 CR +2 09/23/15, 19:43

  17. Wouter Wolters merged patch set 6 09/23/15, 19:43