Review main Merged

43499[BUGFIX] Obsolete construct param in DatabaseQueryProcessor

Sebastian Seidelmann CR +2 V +2 Easy +2 −9 updated 09/23/15, 12:31

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stephan Großberndt +1
    • Sascha Egerer +1
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Sascha Egerer +1
    • Christian Kuhn +1

Issues 1

Files 1

Review log 12

  1. Sebastian Seidelmann uploaded patch set 1 09/23/15, 10:24

  2. Christian Kuhn updated the commit message in patch set 2 09/23/15, 10:29

  3. Christian Kuhn voted on patch set 2 CR +1 09/23/15, 10:34

  4. Stephan Großberndt voted on patch set 2 CR +1 09/23/15, 10:48

  5. Sascha Egerer commented on patch set 2 CR -1 09/23/15, 11:26

    DatabaseQueryProcessor.php:54

    Remove the empty doc block

    DatabaseQueryProcessor.php:63

    Why has this method been removed?
  6. Benjamin Kott uploaded patch set 3 09/23/15, 11:41

  7. Benjamin Kott commented on patch set 2 09/23/15, 11:43

    DatabaseQueryProcessor.php:54 Reply

    Added comment like widely used in the core, seems to be better than a removal.

    DatabaseQueryProcessor.php:63 Reply

    https://review.typo3.org/#/c/42904/6 see helmuts comments here
  8. Stephan Großberndt voted on patch set 3 CR +1 09/23/15, 12:00

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 09/23/15, 12:01

  10. Sascha Egerer voted on patch set 3 CR +1 V +1 09/23/15, 12:07

  11. Georg Ringer voted on patch set 3 CR +2 V +2 09/23/15, 12:30

  12. Georg Ringer merged patch set 3 09/23/15, 12:31