Review main Merged

43509[BUGFIX] Do not call non static methods statically

Helmut Hummel CR +2 V +2 Easy +14 −17 updated 09/23/15, 19:10

Commit message

ClassInformationGenerator used to be a class with static methods.
Remove all static calls to methods which are not static any more.

Also make the property non static, so that we do not have to reset
the state if we do generate the class info twice in one request.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Morton Jonuschat +1
    • Michael Oehlhof +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 7

  1. Helmut Hummel uploaded patch set 1 09/23/15, 18:58

  2. Wouter Wolters updated the commit message in patch set 2 09/23/15, 19:01

  3. Wouter Wolters voted on patch set 2 V +1 CR +1 09/23/15, 19:03

  4. Morton Jonuschat voted on patch set 2 CR +1 V +1 09/23/15, 19:07

  5. Michael Oehlhof voted on patch set 2 CR +1 09/23/15, 19:08

  6. Georg Ringer voted on patch set 2 CR +2 V +2 09/23/15, 19:10

  7. Georg Ringer merged patch set 2 09/23/15, 19:10