Review main Merged

43511[BUGFIX] Adjust visibility of setUp() and tearDown()

Helmut Hummel CR +2 V +2 Normal +55 −55 updated 09/23/15, 19:52

Commit message

Protected is the correct visibility for those functions, as
given by the base class.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Nicole Hummel +1
    • Michael Oehlhof +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Nicole Hummel +1

Issues 1

Files 52

Show 32 more files

Review log 11

  1. Helmut Hummel uploaded patch set 1 09/23/15, 19:28

  2. Georg Ringer voted on patch set 1 CR +1 V +1 09/23/15, 19:33

  3. Wouter Wolters commented on patch set 1 CR -1 09/23/15, 19:33

    PersistenceManager.php:334

    this is wrong.
  4. Helmut Hummel commented on patch set 1 CR -1 09/23/15, 19:34

    tests seem to fail
  5. Helmut Hummel commented on patch set 1 09/23/15, 19:38

    PersistenceManager.php:334 Reply

    oops, yes sure!
  6. Nicole Hummel uploaded patch set 2 09/23/15, 19:39

  7. Nicole Hummel voted on patch set 2 CR +1 V +1 09/23/15, 19:39

  8. Wouter Wolters voted on patch set 2 V +1 CR +1 09/23/15, 19:42

  9. Michael Oehlhof voted on patch set 2 CR +1 09/23/15, 19:47

  10. Georg Ringer voted on patch set 2 CR +2 V +2 09/23/15, 19:51

  11. Georg Ringer merged patch set 2 09/23/15, 19:52