Review main Merged

43531[BUGFIX] need to parse field value for maxitems = 1 with MM table

Andreas Allacher CR +2 V +2 Normal +97 −4 updated 09/25/15, 14:04

Commit message

If a select field has an MM table like sys_category_record_mm
it is necessary to parse the field value even if maxitems = 1
Furthermore, this really fixes #69836 as that was actually
only a workaround.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Markus Sommer +1
  • Verified V +2
    • Morton Jonuschat +2
    • Markus Sommer +1

Issues 1

Files 3

Review log 11

  1. Andreas Allacher uploaded patch set 1 09/24/15, 16:02

  2. Andreas Allacher commented on patch set 1 09/24/15, 17:55

    I also thought I removed the workaround. Will remove those tomorrow.
  3. Morton Jonuschat commented on patch set 1 09/24/15, 19:03

    Please also add a test case to TcaSelectItemsTest
  4. Andreas Allacher uploaded patch set 2 09/25/15, 06:25

  5. Andreas Allacher uploaded patch set 3 09/25/15, 06:27

  6. Andreas Allacher commented on patch set 3 09/25/15, 06:27

    Removed the mentioned workaround and added corresponding tests
  7. Andreas Allacher uploaded patch set 4 09/25/15, 06:28

  8. Morton Jonuschat voted on patch set 4 CR +1 V +1 09/25/15, 07:46

  9. Markus Sommer voted on patch set 4 CR +1 V +1 09/25/15, 12:28

  10. Morton Jonuschat voted on patch set 4 CR +2 V +2 09/25/15, 14:04

  11. Morton Jonuschat merged patch set 4 09/25/15, 14:04