Review main Merged

43535[BUGFIX] Open admin panel backend link in new tab, not a popup

Benni Mack CR +2 V +2 Easy +1 −1 updated 09/25/15, 12:51

Commit message

Simply remove the JavaScript parameters to open the window
in a tab, not a popup.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Sommer +1
    • Jan Helke +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Sommer +1
    • Jan Helke +1

Issues 1

Files 1

Review log 8

  1. Benni Mack uploaded patch set 1 09/24/15, 18:13

  2. Stefan Froemken commented on patch set 1 09/24/15, 19:54

    Yes, the backend was opened in a new tab, but an error occours.

    AdminPanelView.php:449

    TYPO3_mainDir results in "typo3" and getBackendScript results in "typo3/index.php?route=%2Fmain". Hmmm...a little bit too much typo3 ;-)
  3. Jan Helke commented on patch set 1 CR -1 V -1 09/25/15, 09:50

    Can confirm. Try to fix that.
  4. Jan Helke uploaded patch set 2 09/25/15, 09:53

  5. Jan Helke voted on patch set 2 CR +1 V +1 09/25/15, 09:53

  6. Markus Sommer voted on patch set 2 CR +1 V +1 09/25/15, 12:48

  7. Frank Nägler voted on patch set 2 CR +2 V +2 09/25/15, 12:51

  8. Frank Nägler merged patch set 2 09/25/15, 12:51