Review main Merged

43541[TASK] Add a reset search link to filelist searchfield

Wouter Wolters CR +2 V +2 Easy +33 −2 updated 01/09/19, 20:56

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Josef Glatz +1
  • Verified V +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Josef Glatz +1

Issues 1

Files 2

Review log 17

  1. Wouter Wolters uploaded patch set 1 09/24/15, 20:03

  2. Daniel Goerz commented on patch set 1 09/24/15, 20:38

    FileList.js:81

    closing ] missing
  3. Wouter Wolters uploaded patch set 2 09/24/15, 20:42

  4. Daniel Goerz commented on patch set 1 V -1 09/24/15, 20:42

    This is not working for me. I only get the clear icon if I searched for something. On the initial searchfield it does not appear.
  5. Wouter Wolters uploaded patch set 3 09/24/15, 21:00

  6. Daniel Goerz voted on patch set 3 CR +1 V +1 09/24/15, 21:08

  7. Daniel Goerz commented on patch set 3 CR 0 V 0 09/24/15, 21:24

    FileSearch.js:24

    We dont need this callback, dont we? We just want to clear the field not submit the empty form.
  8. Wouter Wolters uploaded patch set 4 09/24/15, 21:41

  9. Daniel Goerz voted on patch set 4 CR +1 V +1 09/24/15, 21:47

  10. Torben Hansen voted on patch set 4 CR +1 V +1 09/25/15, 06:19

  11. Andreas Kienast uploaded patch set 5 09/25/15, 06:52

  12. Andreas Kienast commented on patch set 5 CR +1 V +1 09/25/15, 06:54

    Replaced parents().first() with closest. Although the logic was copied from EM, this is performance wise better as it doesn't traverse the whole DOM. I'll adjust the logic in EM in a separate patch.
  13. Daniel Goerz voted on patch set 5 CR +1 V +1 09/25/15, 07:02

  14. Andreas Kienast voted on patch set 5 CR +2 V +2 09/25/15, 07:10

  15. Andreas Kienast merged patch set 5 09/25/15, 07:10

  16. Josef Glatz voted on patch set 4 CR +1 V +1 01/09/19, 20:56

  17. Josef Glatz voted on patch set 5 CR +1 V +1 01/09/19, 20:56