43542[TASK] Clear button in BE search missing
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Daniel Goerz +1
-
Verified V +2
- Andreas Kienast +2
- Daniel Goerz +1
Issues 1
Files 1
Review log 16
-
Wouter Wolters uploaded patch set 1 09/24/15, 20:41
-
Markus Klein voted on patch set 1 CR +1 V +1 09/24/15, 21:35
-
Wouter Wolters uploaded patch set 2 09/24/15, 21:40
-
Wouter Wolters uploaded patch set 3 09/24/15, 21:42
-
Markus Klein voted on patch set 3 V +2 CR +2 09/24/15, 21:44
-
Daniel Goerz voted on patch set 3 CR +1 V +1 09/24/15, 21:52
-
Markus Klein commented on patch set 3 V 0 09/24/15, 21:55
testing again -
Markus Klein commented on patch set 3 CR 0 09/24/15, 21:57
ok, missed the reload, this protection should be added right away here too. -
Wouter Wolters uploaded patch set 4 09/24/15, 21:59
-
Daniel Goerz voted on patch set 4 CR +1 V +1 09/24/15, 22:03
-
Andreas Kienast uploaded patch set 5 09/25/15, 07:29
-
Andreas Kienast voted on patch set 5 CR +1 V +1 09/25/15, 07:29
-
Andreas Kienast commented on patch set 5 09/25/15, 07:30
Replaced parents().first() with closest. Although the logic was copied from EM, this is performance wise better as it doesn't traverse the whole DOM. I'll adjust the logic in EM in a separate patch. -
Daniel Goerz voted on patch set 5 CR +1 V +1 09/25/15, 07:32
-
Andreas Kienast voted on patch set 5 CR +2 V +2 09/25/15, 08:30
-
Andreas Kienast merged patch set 5 09/25/15, 08:30