Review main Merged

43542[TASK] Clear button in BE search missing

Wouter Wolters CR +2 V +2 Easy +16 −2 updated 09/25/15, 08:30

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2
    • Andreas Kienast +2
    • Daniel Goerz +1

Issues 1

Files 1

Review log 16

  1. Wouter Wolters uploaded patch set 1 09/24/15, 20:41

  2. Markus Klein voted on patch set 1 CR +1 V +1 09/24/15, 21:35

  3. Wouter Wolters uploaded patch set 2 09/24/15, 21:40

  4. Wouter Wolters uploaded patch set 3 09/24/15, 21:42

  5. Markus Klein voted on patch set 3 V +2 CR +2 09/24/15, 21:44

  6. Daniel Goerz voted on patch set 3 CR +1 V +1 09/24/15, 21:52

  7. Markus Klein commented on patch set 3 V 0 09/24/15, 21:55

    testing again
  8. Markus Klein commented on patch set 3 CR 0 09/24/15, 21:57

    ok, missed the reload, this protection should be added right away here too.
  9. Wouter Wolters uploaded patch set 4 09/24/15, 21:59

  10. Daniel Goerz voted on patch set 4 CR +1 V +1 09/24/15, 22:03

  11. Andreas Kienast uploaded patch set 5 09/25/15, 07:29

  12. Andreas Kienast voted on patch set 5 CR +1 V +1 09/25/15, 07:29

  13. Andreas Kienast commented on patch set 5 09/25/15, 07:30

    Replaced parents().first() with closest. Although the logic was copied from EM, this is performance wise better as it doesn't traverse the whole DOM. I'll adjust the logic in EM in a separate patch.
  14. Daniel Goerz voted on patch set 5 CR +1 V +1 09/25/15, 07:32

  15. Andreas Kienast voted on patch set 5 CR +2 V +2 09/25/15, 08:30

  16. Andreas Kienast merged patch set 5 09/25/15, 08:30