Review main Merged

43556[BUGFIX] excludeForPackaging: exclude common files/directories

Josef Glatz CR +2 V +2 Easy +1 −1 updated 01/09/19, 20:56

Commit message

The following common files/directories must be excluded/included
when exporting an extension through the download button in the
extension manager:

* .htaccess
* .sass-cache
* node_modules
* bower_components

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1

Issues 1

Files 1

Review log 7

  1. Josef Glatz uploaded patch set 1 01/09/19, 20:56

  2. Josef Glatz uploaded patch set 2 01/09/19, 20:56

  3. Josef Glatz uploaded patch set 3 01/09/19, 20:56

  4. Josef Glatz rebased onto patch set 3 01/09/19, 20:56

  5. Benni Mack commented on patch set 4 CR +2 V +2 01/09/19, 20:56

    although we can argue about the .htaccess file (some do that on purpose I could imagine), I'm fine with that for now.
  6. Georg Ringer voted on patch set 4 CR +1 V +1 01/09/19, 20:56

  7. Benni Mack merged patch set 4 01/09/19, 20:56