Review main Merged

43568[BUGFIX] Resync composer.json and composer.lock

Anja Leichsenring CR +2 V +2 Easy +4 −3 updated 09/25/15, 13:59

Commit message

composer install issues a warning about composer.lock not being
in sync with composer.json. composer update nothing brings
things back in balance.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stephan Großberndt +1
    • Andreas Kienast +1
    • Morton Jonuschat +1
  • Verified V +2
    • Helmut Hummel +2
    • Andreas Kienast +1
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 10

  1. Anja Leichsenring uploaded patch set 1 09/25/15, 13:09

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 09/25/15, 13:10

  3. Morton Jonuschat voted on patch set 1 CR +1 V +1 09/25/15, 13:11

  4. Stephan Großberndt commented on patch set 1 09/25/15, 13:11

    composer.lock:8

    we did not have a content-hash before. Check with helmut? :-)
  5. Andreas Kienast commented on patch set 1 09/25/15, 13:18

    It seems that content-hash is a new feature in composer: https://github.com/composer/composer/pull/4140/files?diff=split
  6. Stephan Großberndt voted on patch set 1 CR +1 09/25/15, 13:23

  7. Nicole Hummel commented on patch set 1 CR -1 09/25/15, 13:39

    As there were troubles with composer.lock before, please wait for vote by Helmut
  8. Helmut Hummel voted on patch set 1 CR +2 V +2 09/25/15, 13:57

  9. Nicole Hummel voted on patch set 1 CR 0 09/25/15, 13:57

  10. Helmut Hummel merged patch set 1 09/25/15, 13:59