Review main Abandoned

43583[FEATURE] Scheduler: Introduce concept of framework-actions

Stefan Neufeind CR 0 V 0 Normal +139 −13 updated 10/09/15, 17:38

Commit message

An AdditionalFieldProvider can now return framework-actions.

In the scheduler those can be displayed like normal actions which are
directly provided by an extension.
This allows actions from frameworks like Extbase to not appear grouped
under their framework but under the extension they are provided with.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 4

  1. Stefan Neufeind uploaded patch set 1 09/26/15, 20:10

  2. Christian Kuhn commented on patch set 1 CR -1 09/27/15, 11:48

    Not for 7 anymore. Furthermore, this looks more like yet another hack to make the grouping more flexible. I'd rather not introduce another feature to hack around that, but instead think about the root of the problem: Obviously, the separation by extension is limited and needs to change in a sane way. There are two or three planned changes that may indirectly affect this area: the cli execution will probably change by further symfony and and bootstrap works, the additional fields stuff may change in 8 by using FormEngine. I guess it is likely that we will have to think about scheduler registration along the way and could solve the grouping problem, too. Thus, I'd refrain from implementing yet another group-by logic in scheduler for now and live with the current situation just a bit longer.
  3. Oliver Hader uploaded patch set 2 10/09/15, 00:19

  4. Stefan Neufeind abandoned the change 10/09/15, 17:38

    Not wanted. Maybe sometime this will be fixed by other changes along the way.