43608[BUGFIX] Correct typolink section for addQueryString=false
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Daniel Goerz +1
-
Verified V +2
- Stefan Neufeind +2
- Daniel Goerz +1
Issues 1
Files 1
Review log 22
-
Andreas Allacher uploaded patch set 1 09/28/15, 09:11
-
Markus Klein commented on patch set 1 CR -1 10/08/15, 18:40
-
Andreas Allacher commented on patch set 1 10/08/15, 18:50
ContentObjectRenderer.php:6451ReplyAh, yes true :) I thought there was an or somewhere but apparently not :) -
Oliver Hader uploaded patch set 2 10/08/15, 23:56
-
Andreas Allacher uploaded patch set 3 10/10/15, 15:08
-
Andreas Allacher commented on patch set 3 10/10/15, 15:09
@Markus: I remove the unnecessary if now. -
Markus Klein commented on patch set 3 10/11/15, 21:12
ContentObjectRenderer.php:6659you didn't test this patch iteration, right? -
Markus Klein voted on patch set 3 CR -1 10/11/15, 21:12
-
Andreas Allacher commented on patch set 3 10/11/15, 21:15
ContentObjectRenderer.php:6659Replyah damn. No. I tested the last one but I didn't have an installation when I made that change :) -
Andreas Allacher uploaded patch set 4 10/11/15, 21:17
-
Andreas Allacher uploaded patch set 5 10/11/15, 21:19
-
Andreas Allacher commented on patch set 5 10/11/15, 21:20
Just fixed the obvious issue. Will test the new iteration tomorrow because then I have an already "working" example available. -
Andreas Allacher commented on patch set 5 10/12/15, 13:29
OK. I verified that it works correctly now. -
Andreas Bouche commented on patch set 5 CR +1 V +1 10/13/15, 13:53
Works as intended. -
Daniel Goerz updated the commit message in patch set 6 10/13/15, 17:41
-
Andreas Bouche voted on patch set 6 CR +1 V +1 10/14/15, 08:34
-
Daniel Goerz voted on patch set 6 CR +1 V +1 10/29/15, 21:23
-
Stefan Neufeind updated the commit message in patch set 7 10/29/15, 22:36
-
Stefan Neufeind commented on patch set 7 CR +1 V +1 10/29/15, 22:36
fix is okay. discussed commit-msg with Daniel and this is what we came up with. -
Daniel Goerz voted on patch set 7 CR +1 V +1 10/29/15, 22:37
-
Stefan Neufeind voted on patch set 7 CR +2 V +2 10/29/15, 22:56
-
Stefan Neufeind merged patch set 7 10/29/15, 22:56
ContentObjectRenderer.php:6451