Review main Merged

43608[BUGFIX] Correct typolink section for addQueryString=false

Andreas Allacher CR +2 V +2 Easy +13 −10 updated 10/29/15, 22:56

Commit message

If addQueryString is false the query parameters should not
be taken into account. Only the parameters set in the
typolink need to be added before the section mark.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Goerz +1

Issues 1

Files 1

Review log 22

  1. Andreas Allacher uploaded patch set 1 09/28/15, 09:11

  2. Markus Klein commented on patch set 1 CR -1 10/08/15, 18:40

    ContentObjectRenderer.php:6451

    this is always true, due to the outer if condition having the same expression connected with &&
  3. Andreas Allacher commented on patch set 1 10/08/15, 18:50

    ContentObjectRenderer.php:6451 Reply

    Ah, yes true :) I thought there was an or somewhere but apparently not :)
  4. Oliver Hader uploaded patch set 2 10/08/15, 23:56

  5. Andreas Allacher uploaded patch set 3 10/10/15, 15:08

  6. Andreas Allacher commented on patch set 3 10/10/15, 15:09

    @Markus: I remove the unnecessary if now.
  7. Markus Klein commented on patch set 3 10/11/15, 21:12

    ContentObjectRenderer.php:6659

    you didn't test this patch iteration, right?
  8. Markus Klein voted on patch set 3 CR -1 10/11/15, 21:12

  9. Andreas Allacher commented on patch set 3 10/11/15, 21:15

    ContentObjectRenderer.php:6659 Reply

    ah damn. No. I tested the last one but I didn't have an installation when I made that change :)
  10. Andreas Allacher uploaded patch set 4 10/11/15, 21:17

  11. Andreas Allacher uploaded patch set 5 10/11/15, 21:19

  12. Andreas Allacher commented on patch set 5 10/11/15, 21:20

    Just fixed the obvious issue. Will test the new iteration tomorrow because then I have an already "working" example available.
  13. Andreas Allacher commented on patch set 5 10/12/15, 13:29

    OK. I verified that it works correctly now.
  14. Andreas Bouche commented on patch set 5 CR +1 V +1 10/13/15, 13:53

    Works as intended.
  15. Daniel Goerz updated the commit message in patch set 6 10/13/15, 17:41

  16. Andreas Bouche voted on patch set 6 CR +1 V +1 10/14/15, 08:34

  17. Daniel Goerz voted on patch set 6 CR +1 V +1 10/29/15, 21:23

  18. Stefan Neufeind updated the commit message in patch set 7 10/29/15, 22:36

  19. Stefan Neufeind commented on patch set 7 CR +1 V +1 10/29/15, 22:36

    fix is okay. discussed commit-msg with Daniel and this is what we came up with.
  20. Daniel Goerz voted on patch set 7 CR +1 V +1 10/29/15, 22:37

  21. Stefan Neufeind voted on patch set 7 CR +2 V +2 10/29/15, 22:56

  22. Stefan Neufeind merged patch set 7 10/29/15, 22:56