Review main Abandoned

43628[WIP][BUGFIX] External media URL must not rely on direct upload permission

Anja Leichsenring CR 0 V 0 Easy +9 −11 updated 09/29/15, 15:06

Commit message

For media elements the Add media URL button only shows if direct
upload permission is granted to the BE User.
This should not be related.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 5

  1. Anja Leichsenring uploaded patch set 1 09/29/15, 14:10

  2. Anja Leichsenring updated the commit message in patch set 2 09/29/15, 14:11

  3. Nicole Hummel commented on patch set 2 09/29/15, 14:27

    InlineControlContainer.php:553

    Where does the folder come from?
  4. Nicole Hummel commented on patch set 2 09/29/15, 14:33

    InlineControlContainer.php:553 Reply

    Forget it. Just saw the line above ^^
  5. Anja Leichsenring abandoned the change 09/29/15, 15:06

    there is the possibility to add external media URLs to the element browser like any other file. So this patch is plain wrong and therefor abandoned.