Review main Merged Breaking

43643[!!!][TASK] Remove lockSSL=3 option

Benni Mack CR +2 V +2 Normal +39 −33 updated 10/05/15, 10:29

Commit message

The option $TYPO3_CONF_VARS[BE][lockSSL] to only redirect to SSL
for login is removed in favor of having SSL enabled all the
time (lockSSL=1 or lockSSL=2).

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1

Issues 1

Files 5

Review log 14

  1. Benni Mack uploaded patch set 1 09/30/15, 05:50

  2. Helmut Hummel commented on patch set 1 09/30/15, 08:28

    +1 for removing this option. Having only the login SSL but exposing the session id through plain http is a security flaw
  3. Benni Mack updated the commit message in patch set 2 09/30/15, 12:40

  4. Benni Mack updated the commit message in patch set 3 09/30/15, 16:51

  5. Benni Mack uploaded patch set 4 09/30/15, 17:26

  6. Wouter Wolters voted on patch set 4 V +1 CR +1 09/30/15, 17:33

  7. Markus Klein commented on patch set 4 09/30/15, 17:42

    Hm... The usecase of this is: FE via http and BE via https only. So you log into BE and return to FE, where things must be http again.
  8. Benni Mack commented on patch set 4 10/02/15, 08:14

    but if you have lockSSL=3 and an admin that goes to BE directly, it *should* be SSL as well, right?
  9. Helmut Hummel commented on patch set 4 10/02/15, 08:56

    > Hm... The usecase of this is: FE via http and BE via https only. So you log into BE and return to FE, where things must be http again. This setting does not influence *anything* in the frontend. It is only about the backend. lockSSL=3 means that only the login process is on SSL, but after that, the backend is operated via non SSL connection. This potentially exposes the session id which can be seen almost as critical as exposing the password. lockSSL=3 makes no sense at all. If you already have an SSL setup, you really should use it for the complete backend session.
  10. Markus Klein commented on patch set 4 10/02/15, 10:26

    Well, that's the point. If you login to BE via https and work in FE then without SSL, there is no BE session in FE, which is required for some preview features, if I'm right.
  11. Helmut Hummel commented on patch set 4 10/04/15, 12:18

    > If you login to BE via https and work in FE then without SSL, there is no BE session in FE correct. Such setup if only parts of the frontend are allowed to be SSL is not that easy. But lockSSL=3 is no mitigation here. It hides the fact that the session is exposed behind a SSL login. using http for the backend and RSA is the correct (and most easy) option to choose then. Besides that, all these scenarios are configurable on web server side as well. Not much benefit to have it in TYPO3 which lockSSL=3 having the least benefit (I'd say none)
  12. Markus Klein commented on patch set 4 10/04/15, 13:21

    I'm fine with the change, just wondering why this settings was introduced first place at all then.
  13. Helmut Hummel voted on patch set 4 CR +2 V +2 10/05/15, 10:29

  14. Helmut Hummel merged patch set 4 10/05/15, 10:29