Review main Abandoned

43679[TASK] fe_users: Deprecate combined "name"-field

Stefan Neufeind CR 0 V 0 Hard +264 −0 updated 10/10/15, 17:47

Commit message

Separate fields for first_name, middle_name and last_name exist for some time.
Still a legacy-field for a combined "name" is there as well in fe_users-records.
Using that field is now deprecated and it will be removed in TYPO3 CMS 8.

For compatibility "name" still exists but now is a readonly-field by default.
You can reenable the field to be writeable or configure how "name" is
auto-generated from the 3 separate fields in the extension-configuration for
EXT:frontend.

This change follows the approach already used in EXT:tt_address.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 15

  1. Stefan Neufeind uploaded patch set 1 09/30/15, 23:01

  2. Stefan Neufeind commented on patch set 1 09/30/15, 23:03

    This is basically the same approach that tt_address used for quite some time now.

    Settings.php:16

    whitespace
  3. Tymoteusz Motylewski commented on patch set 1 CR -1 10/01/15, 06:56

    I'm not sure if this is a step into correct direction. please read http://www.w3.org/International/questions/qa-personal-names on the topic of names in different regions. It's much more complex than what we're used to. Basicaly the conclusion is to have an input where the user can put "how we should call you" or "Full name".
  4. Andreas Kienast commented on patch set 1 10/01/15, 07:27

    SettingsUtility.php:18

    I guess this will break as tt_address is a 3rd party extension! Do you mean CMS\Frontend instead?

    ext_localconf.php:46

    Tabs instead of spaces, we didn't switch to PSR-2 yet.
  5. Andreas Kienast voted on patch set 1 CR -1 10/01/15, 07:28

  6. Stefan Neufeind commented on patch set 1 10/01/15, 08:13

    SettingsUtility.php:18 Reply

    sure, just an oversight ...
  7. Stefan Neufeind uploaded patch set 2 10/01/15, 08:17

  8. Stefan Neufeind commented on patch set 1 10/01/15, 08:18

    just the basic cleanup
  9. Benni Mack commented on patch set 2 10/01/15, 12:50

    Hey, I looked into that again. For fe_users this is different than tt_address (IMHO). fe_users could be an organization (a user is not per-se a "real life person" mapped to it), and so, a field like that is quite necessary still. What do you think?
  10. Oliver Hader uploaded patch set 3 10/09/15, 00:13

  11. Jigal van Hemert commented on patch set 3 CR -1 10/10/15, 08:33

    I agree with Tymoteusz. The handling of person names should be more flexible instead of targeted to a North American standard with first, middle and last name. Having a generic 'name' field is already a better solution than only the sub fields. I'm leaning towards a -2, but hoping for insight of the patch owner.
  12. Stefan Neufeind commented on patch set 3 10/10/15, 10:25

    For me combined fields are problematic and having a way to split that makes sense. tt_address had the same discussion and decided for separate fields. Interesting that for fe_users people argue in the exact opposite direction. I was under the impression that "name" was less problematic than discussing of what fields an address consists or so. I don't have a problem here to accept different oppinions - I'd just appreciate to have a decision and this and related things (address-details, ...). Currently extensions come up with their own fields, use them in different ways etc.
  13. Andreas Allacher commented on patch set 3 10/10/15, 17:25

    Well for tt_address there was a patch that would have removed it completely once but it was then argued against it because you might really only want to use the name field, e.g. a company or an instition will not have a first and last name. And using the company field would not really be a good idea there either.
  14. Stefan Neufeind abandoned the change 10/10/15, 17:31

    okay, let's put this to an end
  15. Jigal van Hemert commented on patch set 3 10/10/15, 17:47

    It was discussed together with product owner and the conclusion for now is that we can't make a solution that will work in all cases. See forge for more info.