Review main Merged

43694[TASK] Replace editOnClick with pure HTML - Part 2

Benni Mack CR +2 V +2 Hard +200 −71 updated 10/08/15, 16:55

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frans Saris +1
  • Verified V +2
    • Christian Kuhn +2
    • Frans Saris +1

Issues 1

Files 7

Review log 10

  1. Benni Mack uploaded patch set 1 10/01/15, 12:48

  2. Benni Mack updated the commit message in patch set 2 10/01/15, 12:51

  3. Daniel Goerz commented on patch set 2 V -1 10/01/15, 20:13

    Broken Page Module for me: Go to page module, click "edit page properties" on top, click one of the buttons to save or close. I get an empty frame then.
  4. Benni Mack uploaded patch set 3 10/06/15, 06:27

  5. Frans Saris commented on patch set 3 CR -1 10/07/15, 06:37

    VersionModuleController.php:387

    some merge conflict left overs :)
  6. Frans Saris uploaded patch set 4 10/07/15, 06:42

  7. Frans Saris uploaded patch set 5 10/07/15, 07:07

  8. Frans Saris voted on patch set 5 V +1 CR +1 10/07/15, 07:08

  9. Christian Kuhn voted on patch set 5 V +2 CR +2 10/08/15, 16:55

  10. Christian Kuhn merged patch set 5 10/08/15, 16:55