43697[BUGFIX] Cleanup in SelectTreeElement
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Wouter Wolters +1
- Helmut Hummel +1
-
Verified V +2
- Nicole Hummel +2
- Wouter Wolters +1
- Andreas Bouche +1
Issues 1
Files 1
Review log 18
-
Andreas Kienast uploaded patch set 1 10/01/15, 14:07
-
Andreas Kienast commented on patch set 1 CR -1 10/01/15, 14:08
on it -
Andreas Kienast voted on patch set 1 CR 0 10/01/15, 14:09
-
Andreas Kienast uploaded patch set 2 10/01/15, 14:17
-
Nicole Hummel voted on patch set 2 CR +1 10/01/15, 14:25
-
Andreas Kienast updated the commit message in patch set 3 10/01/15, 14:28
-
Nicole Hummel voted on patch set 3 CR +1 10/01/15, 14:30
-
Philipp Wrann voted on patch set 3 CR +1 V +1 10/01/15, 14:36
-
Nicole Hummel voted on patch set 3 V +1 10/01/15, 14:40
-
Helmut Hummel voted on patch set 3 CR -1 10/01/15, 14:51
-
Andreas Bouche voted on patch set 3 CR +1 V +1 10/01/15, 14:51
-
Helmut Hummel commented on patch set 3 10/01/15, 15:01
I added comments also for unrelated things, which do not need to be fixed here, but outline that proper encoding of strings should always only be done directly when put into context. In this very case, the quoting must not be done manually, but with the API method for that in the right contextSelectTreeElement.php:101re-use of $treeData here for a different purpose is pretty ugly I'd rather remove the $itemArray stuff here completely and use do json_encode([$treeData]) belowSelectTreeElement.php:136no escaping of quotes hereSelectTreeElement.php:169it would be more clear what this is if we'd use: json_encode([$treeData]) here directlySelectTreeElement.php:173quoteJsValue hereSelectTreeElement.php:175(int) here please -
Andreas Kienast uploaded patch set 4 10/01/15, 15:21
-
Helmut Hummel commented on patch set 4 CR +1 10/01/15, 15:35
looks good now, thanks! -
Andreas Bouche voted on patch set 4 V +1 10/01/15, 15:36
-
Nicole Hummel voted on patch set 4 CR +2 V +2 10/01/15, 16:39
-
Wouter Wolters voted on patch set 4 V +1 CR +1 10/01/15, 16:45
-
Nicole Hummel merged patch set 4 10/01/15, 16:47