Review main Merged

43707[BUGFIX] EXT:form - Wrong radio/ checkbox handling if no value is set

Ralf Zimmermann CR +2 V +2 Easy +2 −2 updated 01/09/19, 20:56

Commit message

Do not mark a radio or checkbox as selected, if no "value" property
is set within the configuration and no incoming data exists.

Review

  • Code review CR +2
    • Frans Saris +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • Björn Jacob +1
  • Verified V +2
    • Frans Saris +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • Björn Jacob +1

Issues 1

Files 1

Review log 7

  1. Ralf Zimmermann uploaded patch set 1 10/01/15, 15:53

  2. Björn Jacob updated the commit message in patch set 2 10/02/15, 12:26

  3. Björn Jacob commented on patch set 2 V +1 CR +1 10/02/15, 12:36

    After applying the patch it works just great. Also tested it with values for the different elements and combinations with/ without values.
  4. Daniel Goerz voted on patch set 2 CR +1 V +1 10/02/15, 13:02

  5. Frans Saris voted on patch set 2 CR +2 V +2 10/02/15, 13:25

  6. Frans Saris merged patch set 2 10/02/15, 13:25

  7. Josef Glatz voted on patch set 2 CR +1 V +1 01/09/19, 20:56