Review main Merged

43728[BUGFIX] Prevent showing a PHP Warning on usort

Stefan Froemken CR +2 V +2 Easy +1 −1 updated 10/02/15, 16:51

Commit message

Since there is a bug in PHP, this patch
prevents showing a PHP Warning on usort

Review

  • Code review CR +2
    • Frans Saris +2
    • Andreas Allacher +1
    • Daniel Goerz +1
    • Andreas Kienast +1
  • Verified V +2
    • Frans Saris +2
    • Andreas Allacher +1
    • Daniel Goerz +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 7

  1. Stefan Froemken uploaded patch set 1 10/02/15, 07:35

  2. Andreas Kienast commented on patch set 1 CR +1 V +1 10/02/15, 07:40

    Nasty, but it seems to be the only solution according to https://bugs.php.net/bug.php?id=50688
  3. Frans Saris voted on patch set 1 CR +1 V +1 10/02/15, 08:03

  4. Andreas Allacher commented on patch set 1 CR +1 V +1 10/02/15, 08:27

    The only other solution would be to create a second array that includes the translations as e.g. key then create a third array that replaces the original or something like that. Anyway, this works and is for now (until TYPO3 only supports 7.x :) ) probably the easiest solution.
  5. Daniel Goerz voted on patch set 1 CR +1 V +1 10/02/15, 13:21

  6. Frans Saris voted on patch set 1 CR +2 V +2 10/02/15, 16:51

  7. Frans Saris merged patch set 1 10/02/15, 16:51