Review main Merged

43731[BUGFIX] Add available attributes to output of renderer classes

Frans Saris CR +2 V +2 Normal +73 −50 updated 10/03/15, 10:15

Commit message

The available renderer classes now add the attribute values passed as
option to the rendered output.

To keep the output of the available renderer classes consistent the
wrapper div added by the YouTubeRenderer and VimeoRenderer have been
dropped.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1

Issues 1

Files 6

Review log 7

  1. Frans Saris uploaded patch set 1 10/02/15, 08:43

  2. Tobias Wollender voted on patch set 1 CR +1 10/02/15, 09:05

  3. Frans Saris uploaded patch set 2 10/02/15, 11:30

  4. Frans Saris updated the commit message in patch set 3 10/02/15, 12:48

  5. Daniel Goerz voted on patch set 3 CR +1 V +1 10/02/15, 12:58

  6. Wouter Wolters voted on patch set 3 V +2 CR +2 10/03/15, 10:15

  7. Wouter Wolters merged patch set 3 10/03/15, 10:15