Review main Merged

43735[BUGFIX] Fluid form fields only convert identifier objects to identifier

Andreas Allacher CR +2 V +2 Easy +1 −3 updated 10/16/15, 09:39

Commit message

With the change from getValue to getValueAttribute Fluid now converts
all objects to identifier objects which is wrong because there are many
objects that are valid without identifiers.
For instance, ObjectStorage in multiple select field.
Or a object that implements __toString in TextfieldViewHelper.

The change was introduced with commit https://review.typo3.org/42298/

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Stefan Neufeind +1
    • Nicole Hummel +1
  • Verified V +2
    • Morton Jonuschat +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 16

  1. Andreas Allacher uploaded patch set 1 10/02/15, 10:03

  2. Oliver Hader uploaded patch set 2 10/09/15, 00:11

  3. Nicole Hummel commented on patch set 2 CR +1 V +1 10/09/15, 22:37

    Verified by running unit and functional tests
  4. Christian Kuhn commented on patch set 2 10/10/15, 00:22

    could you please link / reference the offending commit or issue?
  5. Andreas Allacher updated the commit message in patch set 3 10/10/15, 08:27

  6. Andreas Allacher updated the commit message in patch set 4 10/10/15, 08:27

  7. Andreas Allacher updated the commit message in patch set 5 10/10/15, 08:27

  8. Andreas Allacher commented on patch set 5 10/10/15, 08:27

  9. Andreas Allacher updated the commit message in patch set 6 10/10/15, 08:28

  10. Andreas Allacher updated the commit message in patch set 7 10/10/15, 08:28

  11. Andreas Allacher commented on patch set 7 10/10/15, 08:28

    Is there a way to make a commitId linkable in the commit message without positing the whole link?
  12. Nicole Hummel updated the commit message in patch set 8 10/13/15, 08:13

  13. Nicole Hummel voted on patch set 8 CR +1 V +1 10/13/15, 08:13

  14. Stefan Neufeind voted on patch set 8 CR +1 10/13/15, 13:48

  15. Morton Jonuschat voted on patch set 8 CR +2 V +2 10/16/15, 09:38

  16. Morton Jonuschat merged patch set 8 10/16/15, 09:39