43738[BUGFIX] Use $GLOBALS['TYPO3_DB'] in first install process
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 25
-
Oliver Eglseder uploaded patch set 1 10/02/15, 11:51
-
Oliver Eglseder uploaded patch set 2 10/02/15, 11:54
-
Josef Glatz updated the commit message in patch set 3 01/09/19, 20:56
-
Christian Kuhn commented on patch set 4 01/09/19, 20:56
hmm .. looks a bit fishy. i'm pretty sure this worked in the past. could you maybe bisect this a bit to see which patch introduced the issue? -
Oliver Eglseder commented on patch set 4 01/09/19, 20:56
The code was introduced in 2e3c9d5e25e5beadafebca949de3e05eeb6f120a "[!!!][TASK] Rewrite install tool" and didn't work back then either. -
Christian Kuhn commented on patch set 4 01/09/19, 20:56
weird. this would mean the issue in there since 6.2 already. are you sure about that? i'd guess this would have been reported earlier already. the reason i want to know that is: i do not like to set $globals['typo3_db'] in this context. this fix is more a hacky fix of some side effect a different code snipped has. at least it looks to me like that. i would want to know the real reason that is going wrong there to determine if this globals addition is really the only solution we do have or if there is something more elegant we could think of. additionally, this change may in turn introduce additional not easy to see side effects. -
Benni Mack commented on patch set 4 01/09/19, 20:56
probably reproducable if only one concurrent connection to the DB server is allowed. -
Christian Kuhn commented on patch set 4 01/09/19, 20:56
wah? one concurrent connection to db? seriously? i think single request webserver ceased to exist in 1985 or so? nah ... -
Oliver Eglseder commented on patch set 4 01/09/19, 20:56
There are two things that differ from normal environments. I use socket connection and the root user. This is nothing you should do in production but for local dev purposes it's good enough. I've talked to some colleagues and most of them using OS X experienced the same issue. BTW: I can open multiple connections in SequelPro with the same credentials, so it's not a limitation of my local MySQL Server. -
Oliver Eglseder commented on patch set 4 01/09/19, 20:56
And another addition: Restarting MySQL after the Exception was thrown solves the Problem, mostly. -
Oliver Hader uploaded patch set 5 01/09/19, 20:56
-
Oliver Eglseder commented on patch set 5 01/09/19, 20:56
Update: The original error is: 'MySQL server has gone away' Before the exception is thrown i can open unlimited connections After the exception is thrown i can connect only one time, globally (cli, apps, php). So it seems that something strange is done with the database which produces irreversible damage until restart. I removed MySQL completely and installed the one from Homebrew. Still same issue. -
Markus Sommer voted on patch set 5 CR +1 V +1 01/09/19, 20:56
-
Helmut Hummel commented on patch set 5 CR -1 01/09/19, 20:56
This imho is a hack that hides another problem we might have. This needs some more investigation (which I cannot provide right now unfortunately) -
Helmut Hummel commented on patch set 5 01/09/19, 20:56
> The original error is: 'MySQL server has gone away' So what we really need to find out is why this happens on some systems and not on others. Any hint is appreciated so we can document how to configure MySQL correctly -
Christian Kuhn voted on patch set 5 CR -1 01/09/19, 20:56
-
Oliver Eglseder commented on patch set 5 01/09/19, 20:56
The more i'm digging, the weirder it gets. I'll post any gathered information into forge, because it's getting too much for these small message boxes. -
Marcus Schwemer commented on patch set 5 V +1 01/09/19, 20:56
Same here ... solves my problem on MacOS with homebrew ... see ticket on forge -
Philipp Gampe commented on patch set 5 01/09/19, 20:56
@Oliver did you check the max_allowed_packet variable in MySQL -
Oliver Eglseder commented on patch set 5 01/09/19, 20:56
@Philipp i checked it with 1M and 16M. (1M is a bad anyways, since TypoScript caches easily exceed 1M on huge sites) -
Marcus Schwemer commented on patch set 5 CR -1 V 0 01/09/19, 20:56
Seems to be an Mac OSX and homebrew related issue. As no other folks are reporting it, we should abandon the patch, but leave the issue open to collect info about it. -
Benni Mack commented on patch set 5 01/09/19, 20:56
I had the same problem on OS X and homebrew as well back then, but adapted my my.cnf and now everything works just fine since a couple of months. let's abandon this patch then. -
Oliver Eglseder abandoned the change 01/09/19, 20:56
only OSX and homebrew related. won't fix for now -
Josef Glatz voted on patch set 4 CR +1 01/09/19, 20:56
-
Josef Glatz updated the commit message in patch set 4 01/09/19, 20:56