Review main Merged

43751[BUGFIX] Set max size of icons below select fields

Frank Nägler CR +2 V +2 Easy +12 −1 updated 10/05/15, 19:42

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Michael Oehlhof +1
  • Verified V +2
    • Wouter Wolters +2
    • Michael Oehlhof +1

Issues 1

Files 3

Review log 21

  1. Frank Nägler uploaded patch set 1 10/02/15, 20:44

  2. Mathias Schreiber voted on patch set 1 CR +1 V +1 10/02/15, 20:46

  3. Daniel Maier voted on patch set 1 CR +1 V +1 10/02/15, 20:59

  4. Michael Oehlhof voted on patch set 1 CR +1 V +1 10/02/15, 21:08

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 10/03/15, 01:11

  6. Christian Kuhn voted on patch set 1 CR 0 V 0 10/03/15, 01:15

  7. Christian Kuhn commented on patch set 1 V -1 10/03/15, 01:18

    hmm, does not really help me. see for select_9 of ext:styleguide, screeni added to issue on forge. if this case is different, please tell me.
  8. Mathias Schreiber commented on patch set 1 CR -2 10/03/15, 06:41

    sorry, just woke up to this... We must not style t3js- prefixes. Those are for JS only
  9. Frank Nägler commented on patch set 1 10/05/15, 07:15

    @Lolli: We can only set a max size, because the icons in some cases must be bigger, like "thumbnails" for backend layouts. So we can use a max size or nothing. @Mattes: If you use a classname as JS-selector you have to use the prefix t3js-. but you can also use t3js- classnames for styling.
  10. Christian Kuhn voted on patch set 1 V 0 10/05/15, 10:57

  11. Mathias Schreiber commented on patch set 1 CR 0 V 0 10/05/15, 10:58

    I am 99.99999% sure that we decided upon clearly separating JS and styling classes
  12. Christian Kuhn voted on patch set 1 CR +1 10/05/15, 11:03

  13. Wouter Wolters commented on patch set 1 10/05/15, 11:03

    lets make that 100% we agreed to use t3js- selectors only for JS stuff and not for styling.
  14. Frank Nägler commented on patch set 1 10/05/15, 11:19

    classes can ever used for styling (that is the reason why it exists), but if JS use a classname as selector, the class must have the prefix t3js- . But I am fine to change it, in this case we should document this decision to prevent discussions in future.
  15. Frank Nägler commented on patch set 1 CR -2 10/05/15, 13:31

    will take care of the t3js-discussion later this evening.
  16. Frank Nägler uploaded patch set 2 10/05/15, 15:52

  17. Frank Nägler voted on patch set 2 CR 0 10/05/15, 15:55

  18. Wouter Wolters voted on patch set 2 V +1 CR +1 10/05/15, 19:30

  19. Michael Oehlhof voted on patch set 2 CR +1 V +1 10/05/15, 19:40

  20. Wouter Wolters voted on patch set 2 V +2 CR +2 10/05/15, 19:42

  21. Wouter Wolters merged patch set 2 10/05/15, 19:42