43754[BUGFIX] EXT:form - Setting a custom action does not work
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Björn Jacob +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Björn Jacob +1
- Philipp Gampe +1
Issues 1
Files 2
Review log 21
-
Ralf Zimmermann uploaded patch set 1 10/02/15, 22:51
-
Björn Jacob updated the commit message in patch set 2 10/05/15, 12:26
-
Björn Jacob commented on patch set 2 CR -1 10/07/15, 09:06
It seems to me that this issue needs a rebuild. The diff on the setup.txt is quite old. -
Ralf Zimmermann uploaded patch set 3 10/07/15, 09:16
-
Ralf Zimmermann voted on patch set 3 CR -1 10/07/15, 09:18
-
Ralf Zimmermann voted on patch set 3 CR 0 10/07/15, 09:24
-
Ralf Zimmermann rebased onto patch set 3 10/07/15, 09:24
-
Björn Jacob commented on patch set 4 CR +1 V +1 10/07/15, 11:00
Added an example form to the issue for testing this. -
Philipp Gampe commented on patch set 4 CR -1 10/07/15, 12:24
are those changes in TS and HTML related to the current patch/problem?setup.txt:24related to this patch?Form.html:29are those changes part of the patch? -
Ralf Zimmermann commented on patch set 4 10/07/15, 12:46
No, its more a cleanup issue -
Björn Jacob commented on patch set 4 10/07/15, 12:56
Okay. Good catch Philipp. It cleans up the url of the action. The url does now not include "empty" parameters like "format" and is shorter since the default arguments are skipped. But you are right. This should be a separate issue. IMHO it is not breaking or deprecating something. Do you think changing the commit message would be enough or do you insist on breaking the patch in 2 parts? -
Philipp Gampe commented on patch set 4 10/07/15, 15:51
yes, I would prefer two patches here -
Ralf Zimmermann uploaded patch set 5 10/07/15, 16:01
-
Philipp Gampe voted on patch set 5 CR +1 V +1 10/07/15, 17:14
-
Wouter Wolters commented on patch set 5 10/07/15, 17:32
FormBuilder.php:465=== -
Wouter Wolters uploaded patch set 6 10/07/15, 17:33
-
Wouter Wolters voted on patch set 6 CR +1 10/07/15, 17:34
-
Philipp Gampe voted on patch set 6 CR +1 V +1 10/08/15, 01:43
-
Björn Jacob voted on patch set 6 CR +1 V +1 10/08/15, 09:38
-
Christian Kuhn voted on patch set 6 CR +2 V +2 10/08/15, 16:27
-
Christian Kuhn merged patch set 6 10/08/15, 16:27