43775[FEATURE] EXT:form - Add HTML4 / HTML5 attributes to the wizard
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Björn Jacob +1
-
Verified V +2
- Wouter Wolters +2
- Björn Jacob +1
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Feature-70332-EXTform-AddHTML4HTML5AttributesToTheWizard.rst1new+220 −0
- typo3/sysext/form/Configuration/PageTS/modWizards.ts3+8 −4
- typo3/sysext/form/Resources/Private/Language/locallang_wizard.xlf1+219 −0
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Attributes.js+481 −3
Review log 20
-
Ralf Zimmermann uploaded patch set 1 10/04/15, 13:42
-
Ralf Zimmermann uploaded patch set 2 10/04/15, 13:57
-
Ralf Zimmermann commented on patch set 2 10/04/15, 14:01
-
Ralf Zimmermann uploaded patch set 3 10/05/15, 12:23
-
Björn Jacob commented on patch set 3 CR -1 10/05/15, 12:44
The feature.rst should carry the whole documentation of all subtasks as well. Please pay attention of newlines after 76 chars ;) -
Ralf Zimmermann wrote 10/05/15, 12:56
Topic set to ext:form html5 -
Ralf Zimmermann wrote 10/05/15, 13:00
Topic changed from ext:form html5 to ext-form-html5 -
Ralf Zimmermann uploaded patch set 4 10/05/15, 13:55
-
Ralf Zimmermann updated the commit message in patch set 5 10/05/15, 13:58
-
Björn Jacob updated the commit message in patch set 6 10/05/15, 13:59
-
Björn Jacob commented on patch set 6 CR -1 10/05/15, 15:31
modWizards.ts:179I'm not able to set a name, i.e. storing it inside the bodyfield and loading and saving the wizard the name field is gone again.modWizards.ts:179What is correct? See line 44: "accept-charset" and here "acceptcharset".locallang_wizard.xlf:187Because this word is freaking long we do get styling issues. So let's break this one into to words: "Content editable". Otherwise we get huge problems in making the left wizard wider and so on. Would need too much effort. -
Ralf Zimmermann uploaded patch set 7 10/05/15, 15:39
-
Björn Jacob commented on patch set 7 CR +1 V +1 10/05/15, 16:22
Tested FORM element. Could add all the described fields. Tested together with some of the sub-tasks. Works as expected. -
Björn Jacob commented on patch set 7 V 0 CR -1 10/06/15, 05:59
The .rst vanished. Please re-add it again :) -
Ralf Zimmermann uploaded patch set 8 10/06/15, 08:38
-
Björn Jacob commented on patch set 8 CR -1 10/06/15, 10:24
Feature-70332-EXTform-AddHTML4HTML5AttributesToTheWizard.rst:223Let's remove this and add a rst to patchset 43775. Over there we can describe the new element in more detail. And the patchsets are decoupled. -
Ralf Zimmermann uploaded patch set 9 10/06/15, 11:02
-
Björn Jacob voted on patch set 9 CR +1 V +1 10/06/15, 14:17
-
Wouter Wolters voted on patch set 9 V +2 CR +2 10/06/15, 19:20
-
Wouter Wolters merged patch set 9 10/06/15, 19:20
modWizards.ts:160