Review main Merged

43780[TASK] EXT:form - Add HTML4 / HTML5 attributes for SELECT to wizard

Ralf Zimmermann CR +2 V +2 Normal +39 −15 updated 10/06/15, 20:55

Commit message

Add new attributes to the wizard element SELECT.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Björn Jacob +1
  • Verified V +2
    • Wouter Wolters +2
    • Björn Jacob +1

Issues 1

Files 2

Review log 14

  1. Ralf Zimmermann uploaded patch set 1 10/04/15, 14:40

  2. Ralf Zimmermann wrote 10/05/15, 12:58

    Topic set to ext:form html5
  3. Ralf Zimmermann wrote 10/05/15, 12:59

    Topic changed from ext:form html5 to ext-form-html5
  4. Björn Jacob commented on patch set 1 10/05/15, 15:39

    SelectJsonElement.php:65

    I did not find any information regarding this translate attribute. Setting this in the BE does not render anything in the FE.
  5. Björn Jacob updated the commit message in patch set 2 10/05/15, 15:40

  6. Björn Jacob updated the commit message in patch set 3 10/05/15, 15:42

  7. Ralf Zimmermann commented on patch set 3 10/05/15, 15:48

  8. Ralf Zimmermann commented on patch set 3 10/05/15, 15:51

    it is already missing in the frontend because its not includes in the typoscript model definition. i will add this after https://review.typo3.org/#/c/43740/ is merged. Currently, it is important that it is written by the wizard.
  9. Björn Jacob updated the commit message in patch set 4 10/05/15, 15:58

  10. Björn Jacob updated the commit message in patch set 5 10/06/15, 19:38

  11. Wouter Wolters voted on patch set 5 V +1 CR +1 10/06/15, 20:34

  12. Björn Jacob commented on patch set 5 V +1 CR +1 10/06/15, 20:48

    Elements are stored and loaded properly. FE output is written accordingly. Also tested it with "multiple = 1". Works like a charm.
  13. Wouter Wolters voted on patch set 5 V +2 CR +2 10/06/15, 20:55

  14. Wouter Wolters merged patch set 5 10/06/15, 20:55